Differential D29540

sendfile: Fix error initialization in sendfile_getobj()
ClosedPublic
Actions

Authored by markj on Apr 1 2021, 7:47 PM.

Tags

None

Referenced Files

	F169747135: D29540.diff
	Wed, Sep 2, 11:01 AM

	F169569239: D29540.id86768.diff
	Tue, Sep 1, 11:01 PM

	F169521737: D29540.id.diff
	Tue, Sep 1, 7:33 PM

	F169510293: D29540.id86706.diff
	Tue, Sep 1, 6:33 PM

	Unknown Object (File)
	Mon, Aug 31, 6:40 AM

	Unknown Object (File)
	Sun, Aug 30, 10:43 PM

	Unknown Object (File)
	Sun, Aug 30, 7:18 PM

	Unknown Object (File)
	Sun, Aug 30, 6:43 PM

Subscribers

Details

Reviewers

jhb
kib
chs

Commits

rG69f4805c3698: sendfile: Fix error initialization in sendfile_getobj()
rG52a99c72b5e1: sendfile: Fix error initialization in sendfile_getobj()

Summary

Reported by: jhb
Fixes: faa998f6ff695
MFC after: 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 1 2021, 7:47 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 1 2021, 7:47 PM

markj requested review of this revision.Apr 1 2021, 7:47 PM

markj added reviewers: jhb, kib, chs.Apr 1 2021, 7:48 PM

Harbormaster completed remote builds in B38260: Diff 86706.Apr 1 2021, 7:48 PM

kib accepted this revision.Apr 1 2021, 8:03 PM

This revision is now accepted and ready to land.Apr 1 2021, 8:03 PM

I'm just waiting to see if the folks who reported this to me can confirm this fixes the issue they were seeing. I've been unable to reproduce it myself locally on my own test boxes. :-/

chs accepted this revision.Apr 1 2021, 11:59 PM

Closed by commit rG52a99c72b5e1: sendfile: Fix error initialization in sendfile_getobj() (authored by markj). · Explain WhyApr 2 2021, 9:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG52a99c72b5e1: sendfile: Fix error initialization in sendfile_getobj().

markj added a commit: rG69f4805c3698: sendfile: Fix error initialization in sendfile_getobj().Apr 3 2021, 3:15 PM

BTW, confirmed this fixed the error Chelsio's QA was seeing internally.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sendfile.c

2 lines

Diff 86768

sys/kern/kern_sendfile.c

Loading...