Page MenuHomeFreeBSD

traceroute6: Fix rights for rcvsock
ClosedPublic

Authored by markj on Mar 31 2021, 10:41 PM.

Details

Summary
  • Always use distinct sockets for send and recv
  • Limit rights on the recv socket
  • Limit rights before entering capability mode

For ICMP6 we were using the same socket for both, and we limited rights
on the socket such that it's impossible to receive anything.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zlei.huang_gmail.com added inline comments.
usr.sbin/traceroute6/traceroute6.c
941

Copy paste typo

946

It looks good entering capability mode before limiting rights. So no need to adjust here.

markj marked an inline comment as done.

Address feedback.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2021, 2:01 PM
This revision was automatically updated to reflect the committed changes.