Page MenuHomeFreeBSD

sysutils/ansible-{kld,sysrc}: Update to latest commit and convert to slave ports
ClosedPublic

Authored by lcook on Mar 27 2021, 4:20 PM.

Details

Summary
  • While here, appease both portfmt and portclippy.

Changes: https://github.com/dlundgren/ansible-freebsd-modules/compare/cf37fc1..537984b

Test Plan

QA:

  • portlint: OK (looks fine).
  • testport: OK (poudriere: 12.2-RELEASE-p4, amd64/i386).

MFH: No (N/A).

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lcook requested review of this revision.Mar 27 2021, 4:20 PM

LGTM!

Very good job. Note that I did not do run testing for this, but I trust you did :-)

This revision is now accepted and ready to land.Mar 28 2021, 6:12 PM
sysutils/ansible-kld/Makefile
28

^ this could pobably be simpliefied to
_LIBRARY?= kld

  • Use _LIBRARY?= instead.
This revision now requires review to proceed.Mar 29 2021, 9:58 AM
lcook added inline comments.
sysutils/ansible-kld/Makefile
28

Thanks! This didn't occur to me. :)

Rebase on main.

This seems to have gone under the radar for me post-git conversion. Are we good to commit now (I'll amend the history as necessary too)?

This revision is now accepted and ready to land.Fri, Apr 16, 9:59 AM