Page MenuHomeFreeBSD
Differential D2940

Update the master_site_n bit about macros.
ClosedPublic
Actions

Authored by mat on Jun 29 2015, 10:50 AM.
Tags
None
Referenced Files
F132020857: D2940.id6575.diff
Mon, Oct 13, 12:37 AM
Unknown Object (File)
Sat, Oct 4, 11:50 PM
Unknown Object (File)
Sun, Sep 28, 8:22 AM
Unknown Object (File)
Sun, Sep 28, 4:30 AM
Unknown Object (File)
Sat, Sep 27, 2:01 AM
Unknown Object (File)
Fri, Sep 26, 3:32 AM
Unknown Object (File)
Mon, Sep 22, 6:30 AM
Unknown Object (File)
Sun, Sep 21, 1:23 AM
View All Files
Subscribers
None

Details

Reviewers
gjb
wblock
Commits
rD46928: Rewrite the master_site_n section to use macros.
Summary

Should be able to see the current version of this here:

http://aragorn.in.absolight.net/d2/master_site_n/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat updated this revision to Diff 6539.Jun 29 2015, 10:50 AM
mat retitled this revision from to Update the master_site_n bit about macros..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: wblock, gjb.
mat set the repository for this revision to rD FreeBSD doc repository - subversion.Jun 29 2015, 10:50 AM
wblock added inline comments.Jun 29 2015, 5:02 PM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
2580 ↗(On Diff #6539)

It might be good to make the SF link to where it is shown in the doc, in case it is not obvious that it stands for Sourceforge.

2582 ↗(On Diff #6539)

I don't understand what this is saying. Is it telling the user to keep it simple, or explaining that it has been made simple for them? Maybe:

This has been simplified as much as possible. See <xref

2594 ↗(On Diff #6539)

Whitespace-only change on this line.

2596 ↗(On Diff #6539)

Missing the opening <example> above?

mat marked 2 inline comments as done.Jun 30 2015, 11:35 AM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
2596 ↗(On Diff #6539)

No, the <para> above was moved from outside to inside the <example> where it made a bit more sense. It's why I reindented it in the first place.

mat updated this revision to Diff 6574.Jun 30 2015, 11:36 AM
mat marked an inline comment as done.

Update.

mat marked 2 inline comments as done.Jun 30 2015, 11:36 AM
mat updated this revision to Diff 6575.Jun 30 2015, 11:44 AM

Expand the example title a bit.

mat updated this object.Jun 30 2015, 2:18 PM
mat updated this revision to Diff 6646.Jul 2 2015, 12:23 PM

rebase
rebase
rebase# Updating D2940: Update the master_site_n bit about macros.

mat updated this revision to Diff 6653.Jul 2 2015, 10:41 PM

rebase

wblock accepted this revision.Jul 5 2015, 1:17 AM
wblock edited edge metadata.

Okay. Please remember to build-test before commit. Thanks!

This revision is now accepted and ready to land.Jul 5 2015, 1:17 AM
Closed by commit rD46928: Rewrite the master_site_n section to use macros. (authored by mat). · Explain WhyJul 6 2015, 9:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
books/
porters-handbook/
makefiles/
19 lines

Diff 6723

View Options

head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml

Loading...