Page MenuHomeFreeBSD

RISC-V: Fix feenableexcept return value
ClosedPublic

Authored by arichardson on Tue, Mar 23, 9:23 AM.

Details

Summary

The man page says "The feenableexcept(), fedisableexcept(), and
fegetexcept() functions return a bitmap of the exceptions that were
unmasked prior to the call.", so we should return zero not -1.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne added a subscriber: mhorne.

I've wondered about this case before, but this solution seems correct.

How well do we do running the fenv tests with this change (and your other recent commits) ?

This revision is now accepted and ready to land.Tue, Mar 23, 1:12 PM

I've wondered about this case before, but this solution seems correct.

How well do we do running the fenv tests with this change (and your other recent commits) ?

This fixes one of the fenv tests. There are more failures that I need to look into.