Differential D29386

RISC-V: Fix feenableexcept return value
ClosedPublic
Actions

Authored by arichardson on Mar 23 2021, 9:23 AM.

Details

Reviewers

mhorne

Group Reviewers

riscv

Commits

rG0eafcef4552c: RISC-V: Fix feenableexcept return value
rGdd5ed53a2f93: RISC-V: Fix feenableexcept return value

Summary

The man page says "The feenableexcept(), fedisableexcept(), and
fegetexcept() functions return a bitmap of the exceptions that were
unmasked prior to the call.", so we should return zero not -1.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Mar 23 2021, 9:23 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2021, 9:23 AM

Harbormaster completed remote builds in B38002: Diff 86179.Mar 23 2021, 9:23 AM

arichardson requested review of this revision.Mar 23 2021, 9:23 AM

I've wondered about this case before, but this solution seems correct.

How well do we do running the fenv tests with this change (and your other recent commits) ?

This revision is now accepted and ready to land.Mar 23 2021, 1:12 PM

In D29386#658222, @mhorne wrote:

I've wondered about this case before, but this solution seems correct.

How well do we do running the fenv tests with this change (and your other recent commits) ?

This fixes one of the fenv tests. There are more failures that I need to look into.

Closed by commit rGdd5ed53a2f93: RISC-V: Fix feenableexcept return value (authored by arichardson). · Explain WhyMar 25 2021, 12:08 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGdd5ed53a2f93: RISC-V: Fix feenableexcept return value.

arichardson added a commit: rG0eafcef4552c: RISC-V: Fix feenableexcept return value.Apr 10 2021, 1:30 PM