Page MenuHomeFreeBSD

git-arc.sh: add commit command
Needs ReviewPublic

Authored by arichardson on Mar 22 2021, 11:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 12 2024, 5:06 AM
Unknown Object (File)
Dec 24 2023, 11:25 PM
Unknown Object (File)
Dec 20 2023, 2:49 AM
Unknown Object (File)
Aug 12 2023, 6:16 AM
Unknown Object (File)
Aug 3 2023, 8:12 PM
Unknown Object (File)
May 20 2023, 12:58 PM
Unknown Object (File)
May 9 2023, 7:04 AM
Unknown Object (File)
May 3 2023, 9:41 PM
Subscribers

Details

Reviewers
markj
Summary

This is like git arc patch, but also creates a git commit for the
phabricator revision and adjusts the commit message to drop unnecessary
tags.

Depends on D28337
Depends on D29374

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37989
Build 34878: arc lint + arc unit

Event Timeline

I'm not sure this is the best name for patch+commit, but I couldn't think of a better one.

This assumes that arcfilter.sh lives in the same directory as git-arc, but my intent was to have git-arc be installed to /usr/local/bin. Will you do the same for arcfilter?

I'd rather see a single command rather than having both "patch" and "commit". I think the functionality you're adding can supersede "patch"'s, or we can have an option which decides whether a commit is created or not. I chose "patch" since that's what the equivalent functionality in arc is called.

I don't really like "commit" as a subcommand name, it seems too hard to intuit what that subcommand actually does. I suggest adding this functionality to "patch". "pull" might be another good subcommand name.