Page MenuHomeFreeBSD

lib/libc/net/nsdispatch.c: Fix missing unlock and add locking annotations
ClosedPublic

Authored by arichardson on Mar 22 2021, 10:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 5:37 PM
Unknown Object (File)
Fri, Jan 17, 6:44 PM
Unknown Object (File)
Mon, Jan 13, 10:11 PM
Unknown Object (File)
Sun, Jan 12, 1:19 PM
Unknown Object (File)
Dec 11 2024, 8:44 AM
Unknown Object (File)
Nov 25 2024, 1:13 AM
Unknown Object (File)
Nov 14 2024, 12:44 PM
Unknown Object (File)
Oct 5 2024, 8:22 AM
Subscribers

Details

Summary

The error cases (goto fin) of _nsdispatch were missing the unlock.

This change also drops the checks for __isthreaded since the pthread stubs
are already no-ops if threads are not being used. Dropping those conditionals
allows clang's thread safety analysis to deal with the file and also makes
the code a bit more readable. While touching the file also add a few more
assertions in debug mode that the right locks are held.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable