Page MenuHomeFreeBSD

lib/libc/net/nsdispatch.c: Fix missing unlock and add locking annotations
ClosedPublic

Authored by arichardson on Mar 22 2021, 10:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 12:51 AM
Unknown Object (File)
Tue, Aug 11, 3:16 PM
Unknown Object (File)
Mon, Aug 10, 11:24 AM
Unknown Object (File)
Mon, Aug 10, 11:24 AM
Unknown Object (File)
Mon, Aug 10, 11:23 AM
Unknown Object (File)
Fri, Aug 7, 8:25 PM
Unknown Object (File)
Thu, Aug 6, 2:39 PM
Unknown Object (File)
Thu, Aug 6, 10:29 AM
Subscribers

Details

Summary

The error cases (goto fin) of _nsdispatch were missing the unlock.

This change also drops the checks for __isthreaded since the pthread stubs
are already no-ops if threads are not being used. Dropping those conditionals
allows clang's thread safety analysis to deal with the file and also makes
the code a bit more readable. While touching the file also add a few more
assertions in debug mode that the right locks are held.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable