Page MenuHomeFreeBSD

lib/libc/net/nsdispatch.c: Fix missing unlock and add locking annotations
ClosedPublic

Authored by arichardson on Mar 22 2021, 10:27 AM.
Tags
None
Referenced Files
F150710740: D29372.diff
Fri, Apr 3, 1:09 PM
Unknown Object (File)
Tue, Mar 31, 6:29 PM
Unknown Object (File)
Tue, Mar 31, 4:31 AM
Unknown Object (File)
Mon, Mar 30, 10:19 PM
Unknown Object (File)
Sat, Mar 28, 5:12 AM
Unknown Object (File)
Fri, Mar 27, 6:32 PM
Unknown Object (File)
Wed, Mar 25, 5:52 AM
Unknown Object (File)
Tue, Mar 24, 11:24 PM
Subscribers

Details

Summary

The error cases (goto fin) of _nsdispatch were missing the unlock.

This change also drops the checks for __isthreaded since the pthread stubs
are already no-ops if threads are not being used. Dropping those conditionals
allows clang's thread safety analysis to deal with the file and also makes
the code a bit more readable. While touching the file also add a few more
assertions in debug mode that the right locks are held.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable