graphics/wayland: enable cr_pid on FreeBSD >= 12.3

[jbeich]

Summary

bug 215202 has been MFC'd to /stable/12, so let's prepare by fixing pid reporting. No need to bump PORTREVISION as poudriere automatically rebuilds all packages on OSVERSION bumps while /stable/12 hasn't bumped __FreeBSD_version yet.

Test Plan

• builds fine on 11.4/12.2/14.0
• /stable/12 tested synthetically by overriding __FreeBSD_version in <sys/param.h>

[jbeich]

Are you waiting for __FreeBSD_version bump on /stable/12? This change maybe important when considering what to upstream.

See also rP569215 and rP569216.

[mat]

graphics/wayland/files/patch-src_wayland-server.c

88

12.3 will have a version of 1203000, I would just put that there and be done with it.

[jbeich]

graphics/wayland/files/patch-src_wayland-server.c

88

Would be inconsistent with 13.0 conditional where -RELEASE uses 1300139 instead. Once 12.2 reaches EOL (about 1 year from now) the conditionals can be dropped, pretending cr_pid was always supported.

DragonFly still lacks cr_pid but also doesn't use (overrides via newport) our port yet.

[jbeich]

Maintainer timeout. Please, don't neglect like the original change.

[zeising]

@mat already gave you feedback which you haven't acted on. I agree with him that you need a good __FreeBSD_version for FreeBSD 12, probably the next bump after the relevant change went into base. If no such bump has happened yet, it is easy enough to ask for it.
You also need to bump portrevision. Even if the packages will be rebuilt by poudriere on OSVERSION bumps, they will normally not be reinstalled in such case.

[jbeich]

In D29360#662886, @zeising wrote:

@mat already gave you feedback which you haven't acted on.

I did act by providing mine but @mat didn't respond. And @mat isn't part of x11, so you can't delegate maintainer's responsibility of picking the preferred solution to him.

need a good __FreeBSD_version for FreeBSD 12, probably the next bump after the relevant change went into base.

Current diff already accounts for the next bump whether that be in a month or in a year when /releng/12.3 is branched.

If no such bump has happened yet, it is easy enough to ask for it.

Bumping __FreeBSD_version breaks KBI compatibility. It will be done during -RELEASE preparation, anyway.

You also need to bump portrevision. Even if the packages will be rebuilt by poudriere on OSVERSION bumps, they will normally not be reinstalled in such case.

Expected but currently nop until OSVERSION bump. Also, ports/ would have to bump PORTREVISION en masse every time headers under /usr/include changed. Why graphics/wayland is special? If x11 did a better job upstreaming this change would be part of vendor code (invisible downstream), picked up via graphics/wayland 1.19.0 -> 1.20.0 update.

[jbeich]

Giving up over bikeshed. I think, blue color (accurate 1202506) is as "good" as red (coarse 1203000), green color (relying on OSVERSION to rebuild packages) is as "good" as orange (bumping PORTREVISION for changes in base/ system). Please, land the change yourself or explicitly request colors instead camouflaging preferences as something obvious to the reader.

graphics/wayland/files/patch-src_wayland-server.c

88

12.3 will have a version of 1203000

It could be 1203001. Post X.0 rounding isn't guaranteed e.g.,

• 9.2 had 902001
• 11.1 had 1101001
• 11.4 had 1104001