Page MenuHomeFreeBSD

devel/coccinelle: Update to 1.0.1
ClosedPublic

Authored by dumbbell on Jun 27 2015, 12:20 PM.
Tags
None
Referenced Files
F104195750: D2926.diff
Wed, Dec 4, 2:47 PM
Unknown Object (File)
Sat, Nov 30, 1:06 PM
Unknown Object (File)
Fri, Nov 29, 8:02 AM
Unknown Object (File)
Sun, Nov 24, 10:38 PM
Unknown Object (File)
Sun, Nov 24, 7:15 AM
Unknown Object (File)
Sat, Nov 23, 4:33 AM
Unknown Object (File)
Sat, Nov 23, 3:38 AM
Unknown Object (File)
Thu, Nov 21, 1:58 PM
Subscribers
None

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell retitled this revision from to devel/coccinelle: Update to 1.0.1.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added a reviewer: kwm.
devel/coccinelle/Makefile
17

Either binary names, package names with versions or full paths. imo in this case having the package name in the BUILD_DEPEND line is good. your sure these ports aren't needed at run time?

38

hmm, just have one comment line saying stripping breaks spatch should be enough I recon.

devel/coccinelle/Makefile
17

To test it, I deinstalled those OCaml modules and ran spatch with my Coccinelle patch and it didn't complain.

Another fact which makes me think they are used at build time only is that the previous version of the port would build the bundled copy of the modules but are not listed in the old pkg-plist.

38

Ok, I will simplify it.

Shorten comment about stripping breaking the executable

BUILD_DEPENDS: Use package name instead of file path

Fix package name syntax in BUILD_DEPENDS

kwm edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2015, 1:34 PM
This revision was automatically updated to reflect the committed changes.