Paths

Table of Contentst

Differential D2926

devel/coccinelle: Update to 1.0.1
ClosedPublic
Actions

Authored by dumbbell on Jun 27 2015, 12:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 30, 1:06 PM

	Unknown Object (File)
	Fri, Nov 29, 8:02 AM

	Unknown Object (File)
	Sun, Nov 24, 10:38 PM

	Unknown Object (File)
	Sun, Nov 24, 7:15 AM

	Unknown Object (File)
	Sat, Nov 23, 4:33 AM

	Unknown Object (File)
	Sat, Nov 23, 3:38 AM

	Unknown Object (File)
	Thu, Nov 21, 1:58 PM

	Unknown Object (File)
	Wed, Nov 20, 4:46 PM

Subscribers

None

Details

Reviewers

Commits

rP390704: devel/coccinelle: Update to 1.0.1

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell updated this revision to Diff 6502.Jun 27 2015, 12:20 PM

dumbbell retitled this revision from to devel/coccinelle: Update to 1.0.1.

dumbbell updated this object.

dumbbell edited the test plan for this revision. (Show Details)

dumbbell added a reviewer: kwm.

dumbbell added a parent revision: D2925: devel/ocaml-parmap: New ocaml module, used by devel/coccinelle.Jun 27 2015, 12:21 PM

kwm added inline comments.Jun 27 2015, 12:31 PM

devel/coccinelle/Makefile
17 ↗	(On Diff #6502)	Either binary names, package names with versions or full paths. imo in this case having the package name in the BUILD_DEPEND line is good. your sure these ports aren't needed at run time?
38 ↗	(On Diff #6502)	hmm, just have one comment line saying stripping breaks spatch should be enough I recon.

dumbbell added inline comments.Jun 27 2015, 12:43 PM

devel/coccinelle/Makefile
17 ↗	(On Diff #6502)	To test it, I deinstalled those OCaml modules and ran `spatch` with my Coccinelle patch and it didn't complain. Another fact which makes me think they are used at build time only is that the previous version of the port would build the bundled copy of the modules but are not listed in the old `pkg-plist`.
38 ↗	(On Diff #6502)	Ok, I will simplify it.

Shorten comment about stripping breaking the executable

BUILD_DEPENDS: Use package name instead of file path

Fix package name syntax in BUILD_DEPENDS

kwm accepted this revision.Jun 27 2015, 1:34 PM

kwm edited edge metadata.

This revision is now accepted and ready to land.Jun 27 2015, 1:34 PM

Closed by commit rP390704: devel/coccinelle: Update to 1.0.1 (authored by dumbbell). · Explain WhyJun 27 2015, 1:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

devel/

coccinelle/

11 lines

4 lines

63 lines

Diff 6510

head/devel/coccinelle/Makefile

Loading...

head/devel/coccinelle/distinfo

Loading...

head/devel/coccinelle/pkg-plist

Loading...