Page MenuHomeFreeBSD
Differential D29224

make only vital packages vital, not their sub-packages
ClosedPublic
Actions

Authored by me_igalic.co on Mar 11 2021, 8:33 PM.

Details

Reviewers
None
Group Reviewers
pkgbase
Commits
rG1516cd873510: pkgbase: make only vital packages vital, not their sub-packages
rG1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages
Summary

make "vital" a replaceable, which defaults to "false" and only set it for
the main clib, utilities and runtime packages, not their sub-packages

PR: 254174

Test Plan

i have not tested this yet.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningrelease/packages/generate-ucl.sh:50SPELL1Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 37781
Build 34670: arc lint + arc unit

Event Timeline

me_igalic.co created this revision.Mar 11 2021, 8:33 PM
Herald added subscribers: Contributor Reviews (base), imp. · View Herald TranscriptMar 11 2021, 8:33 PM
me_igalic.co requested review of this revision.Mar 11 2021, 8:33 PM
Harbormaster completed remote builds in B37781: Diff 85597.Mar 11 2021, 8:33 PM
me_igalic.co updated this revision to Diff 85598.Mar 11 2021, 8:34 PM

fix spelling error

Harbormaster completed remote builds in B37782: Diff 85598.Mar 11 2021, 8:34 PM
me_igalic.co added a reviewer: pkgbase.Mar 11 2021, 8:35 PM
me_igalic.co changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
me_igalic.co added a project: pkgbase.
manu added a subscriber: manu.Mar 11 2021, 9:28 PM

I don't think that the jail package should be vital.
Otherwise that looks good.

manu added inline comments.Mar 11 2021, 9:30 PM
release/packages/generate-ucl.sh
40

clibs should be vital too.

me_igalic.co added inline comments.Mar 11 2021, 10:30 PM
release/packages/generate-ucl.sh
66

well, this is wrong

69

and why are jails vital?

me_igalic.co updated this revision to Diff 85627.Mar 12 2021, 11:57 AM

address @manu's review

Harbormaster completed remote builds in B37792: Diff 85627.Mar 12 2021, 11:57 AM
me_igalic.co marked an inline comment as done.Mar 12 2021, 11:57 AM

addressed in latest update

me_igalic.co retitled this revision from make jail, runtimes & utilities sub-packages non-vital to make only vital packages vital, not their sub-packages.Mar 12 2021, 11:59 AM
me_igalic.co edited the summary of this revision. (Show Details)
me_igalic.co edited the test plan for this revision. (Show Details)
me_igalic.co edited the summary of this revision. (Show Details)Mar 12 2021, 12:27 PM
manu added a comment.Mar 18 2021, 9:34 AM

Looks ok,
Can you rebase your patch against latest main ?
Thanks.

me_igalic.co updated this revision to Diff 85989.Mar 18 2021, 8:21 PM

rebase

Harbormaster completed remote builds in B37930: Diff 85989.Mar 18 2021, 8:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2021, 10:19 AM
Closed by commit rG1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages (authored by me_igalic.co, committed by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages.
ehem_freebsd_m5p.com added a subscriber: ehem_freebsd_m5p.com.Apr 20 2021, 12:54 AM

I'm unsure which commit did it, but at a point near this commit the time taken by release builds drastically decreased. Before this close to 20 hours for an aarch64 cross-build, just over 6 after. Even though I can leave my build machine running, the decrease in latency is very nice. Thank you.

ehem_freebsd_m5p.com awarded a token.Apr 20 2021, 12:55 AM
ehem_freebsd_m5p.com removed a subscriber: ehem_freebsd_m5p.com.
manu added a commit: rG1516cd873510: pkgbase: make only vital packages vital, not their sub-packages.Aug 16 2021, 4:17 PM

Revision Contents
Changeset List

PathSize
release/
packages/
14 lines
2 lines
2 lines
1 line
2 lines

Diff 85597

View Options

release/packages/generate-ucl.sh

Loading...
View Options

release/packages/jail.ucl

Loading...
View Options

release/packages/runtime.ucl

Loading...
View Options

release/packages/template.ucl

Loading...
View Options

release/packages/utilities.ucl

Loading...