Details

Reviewers

None

Group Reviewers

Commits

R10:1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages

Summary

make "vital" a replaceable, which defaults to "false" and only set it for
the main clib, utilities and runtime packages, not their sub-packages

PR: 254174

Test Plan

i have not tested this yet.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	release/packages/generate-ucl.sh:50	SPELL1	Possible Spelling Mistake

Unit

No Unit Test Coverage

Build Status

Buildable 37781
Build 34670: arc lint + arc unit

Event Timeline

me_igalic.co created this revision.Mar 11 2021, 8:33 PM

Herald added subscribers: Contributor Reviews (base), imp. · View Herald TranscriptMar 11 2021, 8:33 PM

me_igalic.co requested review of this revision.Mar 11 2021, 8:33 PM

Harbormaster completed remote builds in B37781: Diff 85597.Mar 11 2021, 8:33 PM

fix spelling error

Harbormaster completed remote builds in B37782: Diff 85598.Mar 11 2021, 8:34 PM

me_igalic.co added a reviewer: pkgbase.Mar 11 2021, 8:35 PM

me_igalic.co changed the repository for this revision from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.

me_igalic.co added a project: pkgbase.

I don't think that the jail package should be vital.
Otherwise that looks good.

manu added inline comments.Mar 11 2021, 9:30 PM

release/packages/generate-ucl.sh
40	clibs should be vital too.

me_igalic.co added inline comments.Mar 11 2021, 10:30 PM

release/packages/generate-ucl.sh
65	well, this is wrong
68	and why are jails vital?

address @manu's review

Harbormaster completed remote builds in B37792: Diff 85627.Mar 12 2021, 11:57 AM

addressed in latest update

me_igalic.co retitled this revision from make jail, runtimes & utilities sub-packages non-vital to make only vital packages vital, not their sub-packages.Mar 12 2021, 11:59 AM

me_igalic.co edited the summary of this revision. (Show Details)

me_igalic.co edited the test plan for this revision. (Show Details)

me_igalic.co edited the summary of this revision. (Show Details)Mar 12 2021, 12:27 PM

Looks ok,
Can you rebase your patch against latest main ?
Thanks.

rebase

Harbormaster completed remote builds in B37930: Diff 85989.Mar 18 2021, 8:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2021, 10:19 AM

Closed by commit R10:1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages (authored by me_igalic.co, committed by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: R10:1c1ff7979571: pkgbase: make only vital packages vital, not their sub-packages.

I'm unsure which commit did it, but at a point near this commit the time taken by release builds drastically decreased. Before this close to 20 hours for an aarch64 cross-build, just over 6 after. Even though I can leave my build machine running, the decrease in latency is very nice. Thank you.

ehem_freebsd_m5p.com awarded a token.Tue, Apr 20, 12:55 AM

ehem_freebsd_m5p.com removed a subscriber: ehem_freebsd_m5p.com.

make only vital packages vital, not their sub-packages
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 85597

release/packages/generate-ucl.sh

release/packages/jail.ucl

release/packages/runtime.ucl

release/packages/template.ucl

release/packages/utilities.ucl

make only vital packages vital, not their sub-packagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 85597

release/packages/generate-ucl.sh

release/packages/jail.ucl

release/packages/runtime.ucl

release/packages/template.ucl

release/packages/utilities.ucl

make only vital packages vital, not their sub-packages
ClosedPublic
Actions

Revision Contents
Changeset List