Page MenuHomeFreeBSD

make only vital packages vital, not their sub-packages

Authored by on Mar 11 2021, 8:33 PM.



make "vital" a replaceable, which defaults to "false" and only set it for
the main clib, utilities and runtime packages, not their sub-packages

PR: 254174

Test Plan

i have not tested this yet.

Diff Detail

R10 FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I don't think that the jail package should be vital.
Otherwise that looks good.


clibs should be vital too.


well, this is wrong


and why are jails vital?

addressed in latest update retitled this revision from make jail, runtimes & utilities sub-packages non-vital to make only vital packages vital, not their sub-packages.Mar 12 2021, 11:59 AM edited the summary of this revision. (Show Details) edited the test plan for this revision. (Show Details)

Looks ok,
Can you rebase your patch against latest main ?

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2021, 10:19 AM
This revision was automatically updated to reflect the committed changes.

I'm unsure which commit did it, but at a point near this commit the time taken by release builds drastically decreased. Before this close to 20 hours for an aarch64 cross-build, just over 6 after. Even though I can leave my build machine running, the decrease in latency is very nice. Thank you.