Page MenuHomeFreeBSD

net/kamailio: Update to 5.4.4
ClosedPublic

Authored by lcook on Mar 10 2021, 3:22 PM.

Details

Summary

While here, appease some of the suggestions by portclippy/portfmt.
Changes: https://www.kamailio.org/pub/kamailio/5.4.4/ChangeLog

Test Plan

QA:

  • portlint: OK (1 WARN).
  • testport: OK (poudriere: 12.2-RELEASE-p4, amd64/i386).

PR: 254187
Submitted by: Dmitry Wagin <dmitry.wagin@ya.ru> (maintainer)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lcook requested review of this revision.Mar 10 2021, 3:22 PM

This port would benefit from some cleanup. It would be better if variables were sorted, especially the option helpers.
When I find things like this, I usually report back to the submitter/maintainer in the PR or I fixed them myself.

Sometimes I sound like Marie Kondo, but... :-)

This port would benefit from some cleanup. It would be better if variables were sorted, especially the options helpers.
When I find things like this, I usually report back to the submitter/maintainer in the PR or I fixed them myself.

Sometimes I sound like Marie Kondo, but... :-)

I thought about ordering the varying OPTIONS too, just didn't know at what point is considered "too much" even though we retain the right to make these changes as we see fit. Though you're right; best to embrace the tidy-up. I'll get to it ;)

This port would benefit from some cleanup. It would be better if variables were sorted, especially the options helpers.
When I find things like this, I usually report back to the submitter/maintainer in the PR or I fixed them myself.

Sometimes I sound like Marie Kondo, but... :-)

I thought about ordering the varying OPTIONS too, just didn't know at what point is considered "too much" even though we retain the right to make these changes as we see fit. Though you're right; best to embrace the tidy-up. I'll get to it ;)

Thanks!

I think it is wise to friendly advise the submitter/maintainer. Sometimes I do it before the commit and sometimes I ask them if they would do the changes themselves
Most people are really receptive to suggestions :-)

Tidy-up the options helpers and sort alphabetically

Tidy-up the options helpers and sort alphabetically

I'll attach this in the bug-report too, just to make sure they're happy with the changes.

Right it appears the maintainer is OK with the changes. Can we ship it? :)

Right it appears the maintainer is OK with the changes. Can we ship it? :)

Sure we can!

This revision is now accepted and ready to land.Mar 10 2021, 9:16 PM
This revision was automatically updated to reflect the committed changes.