net/kamailio: Update to 5.4.4

[lcook]

Summary

While here, appease some of the suggestions by portclippy/portfmt.
Changes: https://www.kamailio.org/pub/kamailio/5.4.4/ChangeLog

Test Plan

QA:

• portlint: OK (1 WARN).
• testport: OK (poudriere: 12.2-RELEASE-p4, amd64/i386).

PR: 254187
Submitted by: Dmitry Wagin <[e-mail]> (maintainer)

[fernape]

This port would benefit from some cleanup. It would be better if variables were sorted, especially the option helpers.
When I find things like this, I usually report back to the submitter/maintainer in the PR or I fixed them myself.

Sometimes I sound like Marie Kondo, but... :-)

[lcook]

In D29188#653433, @fernape wrote:

This port would benefit from some cleanup. It would be better if variables were sorted, especially the options helpers.
When I find things like this, I usually report back to the submitter/maintainer in the PR or I fixed them myself.

Sometimes I sound like Marie Kondo, but... :-)

I thought about ordering the varying OPTIONS too, just didn't know at what point is considered "too much" even though we retain the right to make these changes as we see fit. Though you're right; best to embrace the tidy-up. I'll get to it ;)

[fernape]

In D29188#653434, @lcook wrote:

In D29188#653433, @fernape wrote:

This port would benefit from some cleanup. It would be better if variables were sorted, especially the options helpers.
When I find things like this, I usually report back to the submitter/maintainer in the PR or I fixed them myself.

Sometimes I sound like Marie Kondo, but... :-)

I thought about ordering the varying OPTIONS too, just didn't know at what point is considered "too much" even though we retain the right to make these changes as we see fit. Though you're right; best to embrace the tidy-up. I'll get to it ;)

Thanks!

I think it is wise to friendly advise the submitter/maintainer. Sometimes I do it before the commit and sometimes I ask them if they would do the changes themselves
Most people are really receptive to suggestions :-)

[lcook]

Tidy-up the options helpers and sort alphabetically

[lcook]

In D29188#653481, @lcook wrote:

Tidy-up the options helpers and sort alphabetically

I'll attach this in the bug-report too, just to make sure they're happy with the changes.

[lcook]

Right it appears the maintainer is OK with the changes. Can we ship it? :)

[fernape]

In D29188#653517, @lcook wrote:

Right it appears the maintainer is OK with the changes. Can we ship it? :)

Sure we can!