Page MenuHomeFreeBSD

sed: add deprecation notice for -i .bak
Needs ReviewPublic

Authored by emaste on Mar 8 2021, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 10:10 PM
Unknown Object (File)
Sat, Sep 5, 3:31 AM
Unknown Object (File)
Fri, Sep 4, 3:04 AM
Unknown Object (File)
Thu, Sep 3, 12:42 PM
Unknown Object (File)
Thu, Sep 3, 6:09 AM
Unknown Object (File)
Thu, Sep 3, 1:34 AM
Unknown Object (File)
Wed, Sep 2, 8:51 AM
Unknown Object (File)
Tue, Sep 1, 10:34 PM
Subscribers

Details

Reviewers
kevans
tobik
Summary

PR: 254091

Test Plan

Needs test suite update, posted for discussion.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.
usr.bin/sed/main.c
142

I think the warning sounds like an error and it is not very clear that sed actually goes ahead and changes the file anyway.

val_packett.cool added inline comments.
usr.bin/sed/main.c
138

Hmm. Still considering -i '' non-deprecated — would that really facilitate a transition to the style everyone else uses?