Clarify the text to point out that it only used for GTK applications, and
so that it is not needed for QT applications.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Some picky notes that can mostly be ignored. But I am curious about the icon caching. Thanks!
| Mk/bsd.gnome.mk | ||
|---|---|---|
| 64 ↗ | (On Diff #6466) | In doc, we try to avoid "you" and "your" and would use something more like "If a GTK+ port..., it should use this macro." Comments in Makefiles are not subject to the same rules, but that still sounds better to me. |
| 66 ↗ | (On Diff #6466) | "If the icons are not cached, they will not be displayed." Sorry, does this mean using this macro will cache the icons? So is it really saying "Using this macro insures that icons are cached and will display correctly."? |
| 67 ↗ | (On Diff #6466) | Our doc guidelines suggest spelling out contractions. (Yes, I know, this is a comment. But it's a kind of doc.) |
Comment Actions
With Warren's comments I guess, but maybe there are more places in the Ports Tree which could use English cleanup...