Page MenuHomeFreeBSD
Differential D28987

add safetybelt checks for cache_enter_time() when an NFS server sends a bogus reply
ClosedPublic
Actions

Authored by rmacklem on Feb 28 2021, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 8:39 AM
Unknown Object (File)
Fri, Apr 19, 11:13 PM
Unknown Object (File)
Fri, Mar 29, 1:40 AM
Unknown Object (File)
Jan 29 2024, 3:42 PM
Unknown Object (File)
Dec 31 2023, 8:26 PM
Unknown Object (File)
Dec 23 2023, 3:23 AM
Unknown Object (File)
Sep 30 2023, 11:45 AM
Unknown Object (File)
Sep 22 2023, 11:41 PM
View All 28 Files
Subscribers
None

Details

Reviewers
kib
mjg
Commits
rG3e04ab36ba5c: nfsclient: add checks for a server returning the current directory
Summary

D28969 dealt with a panic in cache_enter_time() where
the vnode referred to the directory.
It would also be possible to get these panics if a broken
NFS server were to return the directory as an new object being
created.

This patch adds checks to avoid the panics and logs
messages to indicate that the server is broken.

Test Plan

Ran connectathon test suite for various mount options.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rmacklem requested review of this revision.Feb 28 2021, 3:55 PM
rmacklem created this revision.
kib accepted this revision.Feb 28 2021, 6:42 PM
This revision is now accepted and ready to land.Feb 28 2021, 6:42 PM
Closed by commit rG3e04ab36ba5c: nfsclient: add checks for a server returning the current directory (authored by rmacklem). · Explain WhyFeb 28 2021, 10:17 PM
This revision was automatically updated to reflect the committed changes.
rmacklem added a commit: rG3e04ab36ba5c: nfsclient: add checks for a server returning the current directory.

Revision Contents
Changeset List

PathSize
sys/
fs/
nfsclient/
38 lines

Diff 84877

View Options

sys/fs/nfsclient/nfs_clvnops.c

Loading...