Differential D28935

zfs: fix handling of unsupported features
ClosedPublic
Actions

Authored by mm on Feb 26 2021, 10:59 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 7:25 PM

	Unknown Object (File)
	Wed, Oct 29, 11:08 AM

	Unknown Object (File)
	Wed, Oct 29, 11:07 AM

	Unknown Object (File)
	Wed, Oct 29, 11:07 AM

	Unknown Object (File)
	Sun, Oct 26, 4:25 PM

	Unknown Object (File)
	Oct 10 2025, 6:44 PM

	Unknown Object (File)
	Oct 10 2025, 6:43 PM

	Unknown Object (File)
	Oct 10 2025, 6:43 PM

View All 100 Files

Subscribers

Details

Reviewers

freqlabs
garga

Commits

rGee36544bd811: zfs: add missing checks for unsupported features
rGc170aa9f37e4: zfs: add missing checks for unsupported features

Summary

After the recent import from OpenZFS it has become possible to import ZFS pools witn an active org.illumos:edonr feature on FreeBSD, leading to a panic. In addition, "zpool status" reported all pools without edonr as upgradable and "zpool upgrade -v" lists edonr in the list of upgradable features.

To avoid the panic and eventual FS corruption we should deploy a fix even before it has been accepted upstream.

Reference:
https://github.com/openzfs/zfs/pull/11653

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mm created this revision.Feb 26 2021, 10:59 AM

Herald added a subscriber: delphij. · View Herald TranscriptFeb 26 2021, 10:59 AM

mm requested review of this revision.Feb 26 2021, 10:59 AM

freqlabs accepted this revision.Feb 26 2021, 6:22 PM

This revision is now accepted and ready to land.Feb 26 2021, 6:22 PM

Closed by commit rGc170aa9f37e4: zfs: add missing checks for unsupported features (authored by mm). · Explain WhyFeb 26 2021, 11:07 PM

This revision was automatically updated to reflect the committed changes.

mm added a commit: rGc170aa9f37e4: zfs: add missing checks for unsupported features.

mm added a commit: rGee36544bd811: zfs: add missing checks for unsupported features.Mar 10 2021, 9:38 AM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

openzfs/

cmd/

zpool/

2 lines

ztest/

3 lines

lib/

libzfs/

libzfs_status.c

2 lines

module/

zcommon/

zfeature_common.c

2 lines

Diff 84770

sys/contrib/openzfs/cmd/zpool/zpool_main.c

Loading...

sys/contrib/openzfs/cmd/ztest/ztest.c

Loading...

sys/contrib/openzfs/lib/libzfs/libzfs_status.c

Loading...

sys/contrib/openzfs/module/zcommon/zfeature_common.c

Loading...