Differential D28935

zfs: fix handling of unsupported features
ClosedPublic
Actions

Authored by mm on Feb 26 2021, 10:59 AM.

Tags

Referenced Files

	F169942156: D28935.id84738.diff
	Thu, Sep 3, 1:19 AM

	F169851617: D28935.diff
	Wed, Sep 2, 6:32 PM

	F169825179: D28935.id84770.diff
	Wed, Sep 2, 4:42 PM

	Unknown Object (File)
	Tue, Sep 1, 6:07 PM

	Unknown Object (File)
	Tue, Sep 1, 5:42 PM

	Unknown Object (File)
	Tue, Sep 1, 1:12 AM

	Unknown Object (File)
	Mon, Aug 31, 7:18 PM

	Unknown Object (File)
	Mon, Aug 31, 4:21 PM

Subscribers

Details

Reviewers

freqlabs
garga

Commits

rGee36544bd811: zfs: add missing checks for unsupported features
rGc170aa9f37e4: zfs: add missing checks for unsupported features

Summary

After the recent import from OpenZFS it has become possible to import ZFS pools witn an active org.illumos:edonr feature on FreeBSD, leading to a panic. In addition, "zpool status" reported all pools without edonr as upgradable and "zpool upgrade -v" lists edonr in the list of upgradable features.

To avoid the panic and eventual FS corruption we should deploy a fix even before it has been accepted upstream.

Reference:
https://github.com/openzfs/zfs/pull/11653

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mm created this revision.Feb 26 2021, 10:59 AM

Herald added a subscriber: delphij. · View Herald TranscriptFeb 26 2021, 10:59 AM

mm requested review of this revision.Feb 26 2021, 10:59 AM

freqlabs accepted this revision.Feb 26 2021, 6:22 PM

This revision is now accepted and ready to land.Feb 26 2021, 6:22 PM

Closed by commit rGc170aa9f37e4: zfs: add missing checks for unsupported features (authored by mm). · Explain WhyFeb 26 2021, 11:07 PM

This revision was automatically updated to reflect the committed changes.

mm added a commit: rGc170aa9f37e4: zfs: add missing checks for unsupported features.

mm added a commit: rGee36544bd811: zfs: add missing checks for unsupported features.Mar 10 2021, 9:38 AM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

openzfs/

cmd/

zpool/

2 lines

ztest/

3 lines

lib/

libzfs/

libzfs_status.c

2 lines

module/

zcommon/

zfeature_common.c

2 lines

Diff 84770

sys/contrib/openzfs/cmd/zpool/zpool_main.c

Loading...

sys/contrib/openzfs/cmd/ztest/ztest.c

Loading...

sys/contrib/openzfs/lib/libzfs/libzfs_status.c

Loading...

sys/contrib/openzfs/module/zcommon/zfeature_common.c

Loading...