Page MenuHomeFreeBSD

Use kinfo_getfile() to implement fdwalk().
ClosedPublic

Authored by jhb on Feb 23 2021, 6:47 PM.
Tags
None
Referenced Files
F103564339: D28904.diff
Tue, Nov 26, 2:05 PM
Unknown Object (File)
Mon, Nov 25, 7:03 AM
Unknown Object (File)
Mon, Nov 25, 7:03 AM
Unknown Object (File)
Mon, Nov 25, 7:03 AM
Unknown Object (File)
Mon, Nov 25, 6:46 AM
Unknown Object (File)
Oct 20 2024, 7:21 PM
Unknown Object (File)
Oct 14 2024, 2:57 AM
Unknown Object (File)
Sep 24 2024, 3:36 AM
Subscribers

Details

Summary

Previously, the kern.file sysctl (which queries the global file table)
was queried and the results saved in an on-stack buffer. With a
sufficiently active system the sysctl's output could overflow the
stack's available space. Instead, switch to kinfo_getfile() from
libutil. This uses a sysctl which queries only the open files for the
current process, and it uses heap space instead of the stack to store
the sysctl output.

PR: 253602
Submittted by: ps (build glue patches)

Test Plan
  • ps@ kept having this port fail to build as its internal tests crashed due to the stack overflow with the old implementation
  • I've tested this on amd64 as part of a poudriere build for my desktop

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37328
Build 34217: arc lint + arc unit