Page MenuHomeFreeBSD

Use kinfo_getfile() to implement fdwalk().
ClosedPublic

Authored by jhb on Feb 23 2021, 6:47 PM.
Tags
None
Referenced Files
F159145086: D28904.id.diff
Wed, Jun 10, 2:51 PM
Unknown Object (File)
Tue, Jun 9, 9:47 AM
Unknown Object (File)
Tue, Jun 9, 7:37 AM
Unknown Object (File)
Sun, Jun 7, 12:54 PM
Unknown Object (File)
Sat, Jun 6, 12:43 PM
Unknown Object (File)
Thu, Jun 4, 10:09 PM
Unknown Object (File)
Thu, Jun 4, 2:00 PM
Unknown Object (File)
Thu, Jun 4, 5:21 AM
Subscribers

Details

Summary

Previously, the kern.file sysctl (which queries the global file table)
was queried and the results saved in an on-stack buffer. With a
sufficiently active system the sysctl's output could overflow the
stack's available space. Instead, switch to kinfo_getfile() from
libutil. This uses a sysctl which queries only the open files for the
current process, and it uses heap space instead of the stack to store
the sysctl output.

PR: 253602
Submittted by: ps (build glue patches)

Test Plan
  • ps@ kept having this port fail to build as its internal tests crashed due to the stack overflow with the old implementation
  • I've tested this on amd64 as part of a poudriere build for my desktop

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable