Page MenuHomeFreeBSD

Use kinfo_getfile() to implement fdwalk().
ClosedPublic

Authored by jhb on Feb 23 2021, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 19, 7:40 PM
Unknown Object (File)
Sat, Jun 15, 8:29 PM
Unknown Object (File)
Tue, Jun 4, 11:16 AM
Unknown Object (File)
May 10 2024, 12:25 AM
Unknown Object (File)
May 10 2024, 12:20 AM
Unknown Object (File)
May 10 2024, 12:19 AM
Unknown Object (File)
May 9 2024, 4:07 PM
Unknown Object (File)
May 1 2024, 4:27 AM
Subscribers

Details

Summary

Previously, the kern.file sysctl (which queries the global file table)
was queried and the results saved in an on-stack buffer. With a
sufficiently active system the sysctl's output could overflow the
stack's available space. Instead, switch to kinfo_getfile() from
libutil. This uses a sysctl which queries only the open files for the
current process, and it uses heap space instead of the stack to store
the sysctl output.

PR: 253602
Submittted by: ps (build glue patches)

Test Plan
  • ps@ kept having this port fail to build as its internal tests crashed due to the stack overflow with the old implementation
  • I've tested this on amd64 as part of a poudriere build for my desktop

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable