Page MenuHomeFreeBSD

Use kinfo_getfile() to implement fdwalk().
ClosedPublic

Authored by jhb on Feb 23 2021, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:50 AM
Unknown Object (File)
Mon, Sep 15, 11:49 PM
Unknown Object (File)
Sep 9 2025, 5:49 AM
Unknown Object (File)
Sep 7 2025, 1:53 PM
Unknown Object (File)
Aug 18 2025, 4:20 PM
Unknown Object (File)
Jul 21 2025, 11:12 PM
Unknown Object (File)
Jul 20 2025, 4:09 AM
Unknown Object (File)
Jul 20 2025, 4:04 AM
Subscribers

Details

Summary

Previously, the kern.file sysctl (which queries the global file table)
was queried and the results saved in an on-stack buffer. With a
sufficiently active system the sysctl's output could overflow the
stack's available space. Instead, switch to kinfo_getfile() from
libutil. This uses a sysctl which queries only the open files for the
current process, and it uses heap space instead of the stack to store
the sysctl output.

PR: 253602
Submittted by: ps (build glue patches)

Test Plan
  • ps@ kept having this port fail to build as its internal tests crashed due to the stack overflow with the old implementation
  • I've tested this on amd64 as part of a poudriere build for my desktop

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable