pf: Add missing python3 requirements
ClosedPublic
Actions

Authored by arichardson on Feb 23 2021, 6:08 PM.

Details

Reviewers

Commits

R10:3150732abb62: tests/sys/netpfil/pf: Add missing python3 requirements
R10:98202829d1b3: tests/sys/netpfil/pf: Add missing python3 requirements

Summary

This also fixes a typo in the dup test that caused the head function to
not be called.

Test Plan

tests are now skipped instead of failing in my images without python3.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson created this revision.Feb 23 2021, 6:08 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptFeb 23 2021, 6:08 PM

arichardson requested review of this revision.Feb 23 2021, 6:08 PM

Harbormaster completed remote builds in B37327: Diff 84570.Feb 23 2021, 6:08 PM

kp added inline comments.Feb 23 2021, 6:21 PM

tests/sys/netpfil/pf/dup.sh
36	That wants to be 'scapy', Scapy requires python, but python doesn't require Scapy.

apply suggested simplification

Harbormaster completed remote builds in B37329: Diff 84576.Feb 23 2021, 6:58 PM

Thanks for the fixes.

This revision is now accepted and ready to land.Feb 23 2021, 6:59 PM

Closed by commit R10:98202829d1b3: tests/sys/netpfil/pf: Add missing python3 requirements (authored by arichardson). · Explain WhyMar 1 2021, 12:57 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: R10:98202829d1b3: tests/sys/netpfil/pf: Add missing python3 requirements.

arichardson added a commit: R10:3150732abb62: tests/sys/netpfil/pf: Add missing python3 requirements.Wed, Mar 17, 10:23 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

checksum.sh

1 line

dup.sh

3 lines

Diff 84892

View Options

tests/sys/netpfil/pf/checksum.sh