Page MenuHomeFreeBSD

boot: fix OBJS to not include BTX's crt0.o
ClosedPublic

Authored by imp on Feb 22 2021, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 12 2024, 6:47 AM
Unknown Object (File)
Nov 12 2024, 6:15 AM
Unknown Object (File)
Oct 17 2024, 10:14 PM
Unknown Object (File)
Oct 6 2024, 3:46 PM
Unknown Object (File)
Oct 4 2024, 3:06 PM
Unknown Object (File)
Oct 4 2024, 11:08 AM
Unknown Object (File)
Oct 4 2024, 12:37 AM
Unknown Object (File)
Oct 1 2024, 2:47 PM
Subscribers

Details

Summary

According to comments in the Makefile, to make pxeboot work (is this still true,
and if so why?) we need to have crt0.o first. We've done this by adding it to
OBJS before all the other .o's are added. However, there's a problem. This also
adds it to the CLEANFILES variable, which causes it to be removed from multiple
places. The dependencies may also cause it to be re-built at a time that's after
boot2 is built. This causes installs to fail because at install time boot2 is
considered to be out of date and the programs to rebuild it are no longer in the
path.

Cope with this problem by just adding it to LDFLAGS instead.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 22 2021, 11:58 PM
imp created this revision.
stand/i386/loader/Makefile
92–103

Likely better words here are needed to describe what's going on...

This revision was not accepted when it landed; it landed in state Needs Review.May 6 2021, 7:10 PM
This revision was automatically updated to reflect the committed changes.