Differential D28752

cryptosoft: Support per-op keys for AES-GCM and AES-CCM.
ClosedPublic
Actions

Authored by jhb on Feb 17 2021, 10:28 PM.

Tags

None

Referenced Files

	F160944984: D28752.id84152.diff
	Mon, Jun 29, 8:06 AM

	Unknown Object (File)
	Sat, Jun 27, 1:22 AM

	Unknown Object (File)
	Wed, Jun 24, 6:47 AM

	Unknown Object (File)
	Tue, Jun 23, 11:36 PM

	Unknown Object (File)
	Tue, Jun 23, 2:55 PM

	Unknown Object (File)
	Tue, Jun 23, 1:07 PM

	Unknown Object (File)
	Sat, Jun 20, 1:20 AM

	Unknown Object (File)
	Mon, Jun 15, 6:50 PM

Subscribers

Details

Reviewers

jmg
cem

Commits

rGc3eec459b643: cryptosoft: Support per-op keys for AES-GCM and AES-CCM.
rGa10020cfe283: cryptosoft: Support per-op keys for AES-GCM and AES-CCM.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 17 2021, 10:28 PM

Herald added a reviewer: jmg. · View Herald TranscriptFeb 17 2021, 10:28 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Feb 17 2021, 10:28 PM

Harbormaster completed remote builds in B37131: Diff 84152.Feb 17 2021, 10:28 PM

There is no good way to test this change. :( I suppose I could add another sysctl that changed /dev/crypto to use per-op instead of per-session keys. GELI is the only in-tree consumer that uses per-op keys currently.

jhb mentioned this in D27834: Reject AES-GCM and AES-CCM sessions with per-op keys..Feb 17 2021, 10:35 PM

cem accepted this revision.Feb 18 2021, 2:00 AM

This revision is now accepted and ready to land.Feb 18 2021, 2:00 AM

Closed by commit rGa10020cfe283: cryptosoft: Support per-op keys for AES-GCM and AES-CCM. (authored by jhb). · Explain WhyFeb 18 2021, 5:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa10020cfe283: cryptosoft: Support per-op keys for AES-GCM and AES-CCM..

jhb added a commit: rGc3eec459b643: cryptosoft: Support per-op keys for AES-GCM and AES-CCM..Oct 21 2021, 5:07 PM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

6 lines

Diff 84218

sys/opencrypto/cryptosoft.c

Loading...