Page MenuHomeFreeBSD

ddb: just move cursor when the lexer backs up
ClosedPublic

Authored by rlibby on Feb 17 2021, 6:56 AM.

Details

Summary

Get rid of db_look_char because it's not compatible with db_get_line().
This fixes the following issue:

db> script lockinfo=show alllocks
db> run lockinfo
db:0:lockinfo> how alllocks
No such command; use "help" to list available commands

Reported by: markj

Test Plan
db> script lockinfo=show alllocks
db> script lockinfo

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thank you!

sys/ddb/db_lex.c
113

Convert to an ANSI definition while here?

This revision is now accepted and ready to land.Feb 17 2021, 4:16 PM

markj feedback: ANSI-fy while here

This revision now requires review to proceed.Feb 17 2021, 4:28 PM
This revision is now accepted and ready to land.Feb 17 2021, 4:37 PM