Differential D28725

ddb: just move cursor when the lexer backs up
ClosedPublic
Actions

Authored by rlibby on Feb 17 2021, 6:56 AM.

Details

Reviewers

markj

Commits

rGd8404b7ec36d: ddb: just move cursor when the lexer backs up

Summary

Get rid of db_look_char because it's not compatible with db_get_line().
This fixes the following issue:

db> script lockinfo=show alllocks
db> run lockinfo
db:0:lockinfo> how alllocks
No such command; use "help" to list available commands

Reported by: markj

Test Plan

db> script lockinfo=show alllocks
db> script lockinfo

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Feb 17 2021, 6:56 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 6:56 AM

rlibby requested review of this revision.Feb 17 2021, 6:56 AM

Harbormaster completed remote builds in B37086: Diff 84068.Feb 17 2021, 6:56 AM

Thank you!

sys/ddb/db_lex.c
113	Convert to an ANSI definition while here?

This revision is now accepted and ready to land.Feb 17 2021, 4:16 PM

markj feedback: ANSI-fy while here

This revision now requires review to proceed.Feb 17 2021, 4:28 PM

Harbormaster completed remote builds in B37095: Diff 84094.Feb 17 2021, 4:28 PM

markj accepted this revision.Feb 17 2021, 4:37 PM

This revision is now accepted and ready to land.Feb 17 2021, 4:37 PM

Closed by commit rGd8404b7ec36d: ddb: just move cursor when the lexer backs up (authored by rlibby). · Explain WhyFeb 25 2021, 12:00 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rGd8404b7ec36d: ddb: just move cursor when the lexer backs up.

Revision Contents
Changeset List

Path

Size

sys/

ddb/

db_lex.c

27 lines

Diff 84639

View Options

ddb: just move cursor when the lexer backs upClosedPublicActions