Differential D28694

pf tests: Test unicast reverse path forwarding check
ClosedPublic
Actions

Authored by kp on Feb 15 2021, 10:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 19 2024, 8:33 AM

	Unknown Object (File)
	Oct 2 2024, 7:05 PM

	Unknown Object (File)
	Oct 2 2024, 5:25 PM

	Unknown Object (File)
	Oct 1 2024, 2:57 AM

	Unknown Object (File)
	Sep 27 2024, 12:29 PM

	Unknown Object (File)
	Sep 27 2024, 5:16 AM

	Unknown Object (File)
	Sep 24 2024, 9:23 AM

	Unknown Object (File)
	Sep 5 2024, 11:57 AM

View All 49 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG04535d6a572a: pf tests: Test unicast reverse path forwarding check
rG6b52139eb8e8: pf tests: Test unicast reverse path forwarding check

Summary

Ensure that pf's urpf-failed keyword works as expected.

PR: 253479
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Feb 15 2021, 10:18 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptFeb 15 2021, 10:18 PM

Harbormaster completed remote builds in B37041: Diff 83971.Feb 15 2021, 10:18 PM

kp requested review of this revision.Feb 15 2021, 10:18 PM

melifaro accepted this revision.Feb 15 2021, 10:26 PM

melifaro added inline comments.

tests/sys/netpfil/pf/pass_block.sh
209	Nit: maybe it's worth to name the jail according to the test, like "jls_pf_urpf"? This will allow running this test independent of others.

This revision is now accepted and ready to land.Feb 15 2021, 10:26 PM

kp added inline comments.Feb 16 2021, 8:18 AM

tests/sys/netpfil/pf/pass_block.sh
209	The name of the jail is only part of the issue. We also re-use IP ranges (because we use documentation IP ranges and there are only so many to go around), so even with different names the tests could not run in parallel. If we want to get there it would probably make more sense to have the framework start the test in its own vnet jail. That is, we could nest the jails, and at that point the conflicting names or IP ranges wouldn't be an issue.

Closed by commit rG6b52139eb8e8: pf tests: Test unicast reverse path forwarding check (authored by kp). · Explain WhyFeb 16 2021, 10:51 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6b52139eb8e8: pf tests: Test unicast reverse path forwarding check.

kp added a commit: rG04535d6a572a: pf tests: Test unicast reverse path forwarding check.Feb 23 2021, 11:51 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

common/

52 lines

pf/

67 lines

Diff 83999

tests/sys/netpfil/common/pft_ping.py

Loading...

tests/sys/netpfil/pf/pass_block.sh

Loading...