Page MenuHomeFreeBSD

pf tests: Test unicast reverse path forwarding check
ClosedPublic

Authored by kp on Mon, Feb 15, 10:18 PM.

Details

Summary

Ensure that pf's urpf-failed keyword works as expected.

PR: 253479
MFC after: 1 week

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Mon, Feb 15, 10:18 PM
melifaro added inline comments.
tests/sys/netpfil/pf/pass_block.sh
208

Nit: maybe it's worth to name the jail according to the test, like "jls_pf_urpf"?
This will allow running this test independent of others.

This revision is now accepted and ready to land.Mon, Feb 15, 10:26 PM
tests/sys/netpfil/pf/pass_block.sh
208

The name of the jail is only part of the issue.

We also re-use IP ranges (because we use documentation IP ranges and there are only so many to go around), so even with different names the tests could not run in parallel.

If we want to get there it would probably make more sense to have the framework start the test in its own vnet jail. That is, we could nest the jails, and at that point the conflicting names or IP ranges wouldn't be an issue.