Page MenuHomeFreeBSD

fix getdirentries man page for NFS client returning d_off == 0
ClosedPublic

Authored by rmacklem on Feb 14 2021, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 6:01 PM
Unknown Object (File)
Jan 15 2024, 7:46 AM
Unknown Object (File)
Nov 8 2023, 10:24 PM
Unknown Object (File)
Oct 25 2023, 1:45 PM
Unknown Object (File)
Oct 7 2023, 9:15 PM
Unknown Object (File)
Sep 17 2023, 12:21 PM
Unknown Object (File)
Sep 17 2023, 12:21 PM
Unknown Object (File)
Sep 2 2023, 4:00 PM
Subscribers
None

Details

Summary

PR3253428 reported that getdirentries(2) was
returning dirents with d_off set to 0 for an NFS
mount.

This is believed to be correct behaviour at
this time (it may change for some NFS mounts
in the future), but is inconsistent with what the
getdirentries(2) man page says.

This patch fixes the man page.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rmacklem created this revision.
lib/libc/sys/getdirentries.2
95

I find this confusing. Is the antecedent of "it" "cookie", "directory descriptor", or "entry"? I would say "returns a cookie which, if non-zero, can be used with lseek to position the directory descriptor to the next entry."

151

I would shorten this to "if non-zero".

Apply changes suggested by asomers@.

Marked inline comments as done.

Approved, but you should fix the bug number in the commit message.

This revision is now accepted and ready to land.Feb 14 2021, 10:34 PM
This revision was automatically updated to reflect the committed changes.