Page MenuHomeFreeBSD

fix getdirentries man page for NFS client returning d_off == 0
ClosedPublic

Authored by rmacklem on Sun, Feb 14, 4:34 PM.

Details

Summary

PR3253428 reported that getdirentries(2) was
returning dirents with d_off set to 0 for an NFS
mount.

This is believed to be correct behaviour at
this time (it may change for some NFS mounts
in the future), but is inconsistent with what the
getdirentries(2) man page says.

This patch fixes the man page.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rmacklem created this revision.
lib/libc/sys/getdirentries.2
94

I find this confusing. Is the antecedent of "it" "cookie", "directory descriptor", or "entry"? I would say "returns a cookie which, if non-zero, can be used with lseek to position the directory descriptor to the next entry."

151

I would shorten this to "if non-zero".

Apply changes suggested by asomers@.

Marked inline comments as done.

Approved, but you should fix the bug number in the commit message.

This revision is now accepted and ready to land.Sun, Feb 14, 10:34 PM
This revision was automatically updated to reflect the committed changes.