sbin/pfctl: fix tests after recent output changes
ClosedPublic
Actions

Authored by arichardson on Feb 4 2021, 4:03 PM.

Details

Reviewers

kp
pfg

Commits

rGda80e76821e7: sbin/pfctl: fix tests after recent output changes
rG58de61b9967b: sbin/pfctl: fix tests after recent output changes

Summary

The output now contains http-alt instead of 8080 and personal-agent
instead of 5555.
This was probably caused by 228e2087a32847fa51168f3f0c58f931cb2cb0f8.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Feb 4 2021, 4:03 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2021, 4:03 PM

arichardson requested review of this revision.Feb 4 2021, 4:03 PM

Harbormaster completed remote builds in B36701: Diff 83353.Feb 4 2021, 4:03 PM

I wonder if we should teach these tests to use only numeric representations for ports (i.e. 'pfctl -P').
That'd remove the dependency on the services file, but we wouldn't test the symbolic name to port number conversion code any more.

This revision is now accepted and ready to land.Feb 4 2021, 4:20 PM

Closed by commit rG58de61b9967b: sbin/pfctl: fix tests after recent output changes (authored by arichardson). · Explain WhyFeb 4 2021, 5:58 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG58de61b9967b: sbin/pfctl: fix tests after recent output changes.

arichardson added a commit: rGda80e76821e7: sbin/pfctl: fix tests after recent output changes.Mar 17 2021, 10:30 AM