Page MenuHomeFreeBSD

sbin/pfctl: fix tests after recent output changes
ClosedPublic

Authored by arichardson on Thu, Feb 4, 4:03 PM.

Details

Summary

The output now contains http-alt instead of 8080 and personal-agent
instead of 5555.
This was probably caused by 228e2087a32847fa51168f3f0c58f931cb2cb0f8.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I wonder if we should teach these tests to use only numeric representations for ports (i.e. 'pfctl -P').
That'd remove the dependency on the services file, but we wouldn't test the symbolic name to port number conversion code any more.

This revision is now accepted and ready to land.Thu, Feb 4, 4:20 PM