Page MenuHomeFreeBSD

Convert vendor imports to git instructions
ClosedPublic

Authored by imp on Feb 4 2021, 1:12 AM.
Tags
None
Referenced Files
F83464965: D28474.id83338.diff
Fri, May 10, 7:57 PM
Unknown Object (File)
Sun, Apr 21, 10:24 PM
Unknown Object (File)
Sun, Apr 21, 10:24 PM
Unknown Object (File)
Sun, Apr 21, 10:24 PM
Unknown Object (File)
Sun, Apr 21, 10:24 PM
Unknown Object (File)
Sat, Apr 20, 7:24 AM
Unknown Object (File)
Mar 10 2024, 1:13 PM
Unknown Object (File)
Feb 9 2024, 2:22 AM
Subscribers

Details

Test Plan

This is my first major doc contribution...

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 4 2021, 1:12 AM
imp created this revision.
imp added reviewers: Doc Committers, doceng.
rpokala added inline comments.
documentation/content/en/books/developers-handbook/policies/chapter.adoc
83–97

When not referring to the git command itself, consistently use either "git" or "Git".

emaste added inline comments.
documentation/content/en/books/developers-handbook/policies/chapter.adoc
80–81

Certainly reasonable to replace svn docs with git docs, but perhaps as a second step we ought to move this with the rest of the git docs.

87–88

Just "and are visible by default." maybe

I think the "prior drafts" could be a note/caution or just something we follow up with email; most folks will read this for the first time and there's no prior draft of this doc in this form (in dev handbook).

199

We might want to suggest pushing the changes somewhere (e.g. a GitHub fork) for review, as a later change

202

Explicit branch name? git push freebsd main

204

We should probably reference "The conventional approach in FreeBSD is..." instead of or in addition to "easiest", there may be more than one way to do it, but we should have an explicit recommendation IMO.

documentation/content/en/books/developers-handbook/policies/chapter.adoc
80–81

should be replaced by a reference. And the previous policy likely needs to be tweaked to be less prescriptive. But another day.

83–97

yea, git is the command Git is the whole system...

87–88

Tweaked. I think we can just dropped the prior drafts thing. We've had over a week to transition.

199

sure, here and below.

imp edited the test plan for this revision. (Show Details)

review changes

This revision is now accepted and ready to land.Feb 4 2021, 5:35 PM
This revision was automatically updated to reflect the committed changes.