Page MenuHomeFreeBSD

ktls(4): Add comment about the enabled OpenSSL support for aarch64 and amd64
ClosedPublic

Authored by gbe on Sun, Jan 31, 2:01 PM.

Details

Summary

ktls(4): Add comment about the enabled OpenSSL support for aarch64 and amd64

Since KTLS is enabled for aarch64 and amd64 and the shipped OpenSSL version
has also support for KTLS, the man page shoud be updated to reflect this.

Test Plan

mandoc output review and 'mandoc -Tlint' checks.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gbe requested review of this revision.Sun, Jan 31, 2:01 PM

Could some one review this? I would like to get it into releng/13.

Given the serf bug, I'm not sure yet if I really want to merge the OpenSSL bits into 13.0 or not, and if they will be available in 13 at all or not. I would perhaps reword the sentence though as something like:

OpenSSL in the base system includes KTLS support when built with
.Dv WITH_OPENSSL_KTLS
which is enabled by default on aarch64 and amd64.

And then add an .Xr src.conf.5 to the SEE ALSO section.

Given what we decided for 13 (not enable by default), I would amend my earlier suggestion to end the sentence after ".Dv WITH_OPENSSL_KTLS ." and not mention defaults at all. src.conf(5) should probably be the canonical place to describe the default setting of that knob on a given release or branch.

@jhb I updated the differential according to your comments.

This revision is now accepted and ready to land.Sat, Feb 6, 9:32 PM