Differential D28331

usr.sbin/pkg: Don't re-define roundup2
ClosedPublic
Actions

Authored by arichardson on Jan 25 2021, 2:42 PM.

Tags

None

Referenced Files

	F173265265: D28331.diff
	Thu, Sep 24, 8:02 PM

	Unknown Object (File)
	Sun, Sep 20, 4:15 AM

	Unknown Object (File)
	Sat, Sep 19, 2:15 AM

	Unknown Object (File)
	Sat, Sep 19, 2:11 AM

	Unknown Object (File)
	Sat, Sep 19, 1:45 AM

	Unknown Object (File)
	Sun, Sep 13, 10:17 AM

	Unknown Object (File)
	Tue, Sep 8, 11:27 PM

	Unknown Object (File)
	Tue, Sep 8, 5:20 PM

Subscribers

None

Details

Reviewers

bapt
bdrewery

Commits

rGa259db87edfe: usr.sbin/pkg: Don't re-define roundup2
rGc669cd841847: usr.sbin/pkg: Don't re-define roundup2
rG9a0a48b12d3d: usr.sbin/pkg: Don't re-define roundup2

Summary

The file already includes sys/param.h and should use that definition.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jan 25 2021, 2:42 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptJan 25 2021, 2:42 PM

arichardson requested review of this revision.Jan 25 2021, 2:42 PM

Harbormaster completed remote builds in B36466: Diff 82846.Jan 25 2021, 2:42 PM

arichardson mentioned this in D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2.Jan 25 2021, 9:22 PM

arichardson added a child revision: D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2.

Since this is a trivial cleanup, I'll commit this on Monday unless there's any objection.

bapt accepted this revision.Jan 28 2021, 5:24 PM

This revision is now accepted and ready to land.Jan 28 2021, 5:24 PM

Closed by commit rG9a0a48b12d3d: usr.sbin/pkg: Don't re-define roundup2 (authored by arichardson). · Explain WhyJan 28 2021, 5:41 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG9a0a48b12d3d: usr.sbin/pkg: Don't re-define roundup2.

bapt added a commit: rGc669cd841847: usr.sbin/pkg: Don't re-define roundup2.May 5 2021, 8:25 AM

arichardson added a commit: rGa259db87edfe: usr.sbin/pkg: Don't re-define roundup2.Jul 5 2021, 9:47 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pkg/

2 lines

Diff 83064

usr.sbin/pkg/config.c

Loading...