Page MenuHomeFreeBSD

[NEW PORT] www/amfora: Fancy terminal browser for the Gemini protocol
ClosedPublic

Authored by lcook on Jan 24 2021, 7:11 PM.

Details

Summary

Amfora aims to be the best looking Gemini
client with the most features... all in
the terminal. It does not support Gopher
or other non-Web protocols - check out
Bombadillo for that.

It fully passes Sean Conman's client
torture test, as well as the Egsam one.

WWW: https://github.com/makeworld-the-better-one/amfora

QA:

  • portlint: OK (looks fine).
  • testport: OK (poudriere: 12.2-RELEASE-p2, amd64).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lcook requested review of this revision.Jan 24 2021, 7:11 PM
fernape requested changes to this revision.Jan 25 2021, 5:10 PM

There is no pkg-plist or PLIST_FILES:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amfora
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
This revision now requires changes to proceed.Jan 25 2021, 5:10 PM

There is no pkg-plist or PLIST_FILES:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amfora
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

*facepalms* Yep, thanks for the catch. Apparently I missed adding PLIST_FILES= bin/${PORTNAME}. Will update now :-)

  • *Actually* install the amfora binary by adding it to the PLIST_FILES.

There is no pkg-plist or PLIST_FILES:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amfora
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

*facepalms* Yep, thanks for the catch. Apparently I missed adding PLIST_FILES= bin/${PORTNAME}. Will update now :-)

No worries. Just be completely sure that it passes poudriere ;-)

Also, for new ports, linimon@ recommends to do a make describe in the port and possibly in the whole tree to make sure we don't break INDEX. portlint is supposed to do that check as well.

Overall, very good job.

Macro shipit:

This revision is now accepted and ready to land.Jan 26 2021, 8:13 AM