[NEW PORT] www/amfora: Fancy terminal browser for the Gemini protocol

[lcook]

Summary

Amfora aims to be the best looking Gemini
client with the most features... all in
the terminal. It does not support Gopher
or other non-Web protocols - check out
Bombadillo for that.

It fully passes Sean Conman's client
torture test, as well as the Egsam one.

WWW: https://github.com/makeworld-the-better-one/amfora

QA:

• portlint: OK (looks fine).
• testport: OK (poudriere: 12.2-RELEASE-p2, amd64).

[fernape]

There is no pkg-plist or PLIST_FILES:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amfora
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

[lcook]

In D28324#633734, @fernape wrote:

There is no pkg-plist or PLIST_FILES:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amfora
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

*facepalms* Yep, thanks for the catch. Apparently I missed adding PLIST_FILES= bin/${PORTNAME}. Will update now :-)

[lcook]

• *Actually* install the amfora binary by adding it to the PLIST_FILES.

[fernape]

In D28324#633740, @lcook wrote:

In D28324#633734, @fernape wrote:

There is no pkg-plist or PLIST_FILES:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amfora
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

*facepalms* Yep, thanks for the catch. Apparently I missed adding PLIST_FILES= bin/${PORTNAME}. Will update now :-)

No worries. Just be completely sure that it passes poudriere ;-)

Also, for new ports, linimon@ recommends to do a make describe in the port and possibly in the whole tree to make sure we don't break INDEX. portlint is supposed to do that check as well.

Overall, very good job.