Page MenuHomeFreeBSD

security/vuxml: fix validate target due to split of files
ClosedPublic

Authored by mfechner on Jan 23 2021, 8:16 AM.
Tags
None
Referenced Files
F106149518: D28299.diff
Thu, Dec 26, 5:21 AM
Unknown Object (File)
Nov 23 2024, 4:11 AM
Unknown Object (File)
Nov 21 2024, 4:18 PM
Unknown Object (File)
Nov 13 2024, 4:09 PM
Unknown Object (File)
Nov 13 2024, 4:02 PM
Unknown Object (File)
Nov 12 2024, 11:17 PM
Unknown Object (File)
Nov 12 2024, 8:26 PM
Unknown Object (File)
Nov 12 2024, 5:39 AM
Subscribers
None

Details

Summary

Currently the validate target does not work.
This should fix it, it also shows some possible errors, but I do not know the process in detail, so someone else should look onto it.

The validate target no uses the vuln-flat.xml file.
Added a port-clean target to get rid of files you want not to commit.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mfechner created this revision.
mfechner added a reviewer: bapt.

I think Baptiste is a better person to review this change.

Would be nice to have context within the diff that would help reviewing ;)

I am not sure diffing against the entire file is a good idea, first of all the entity declaration is still lost by tidy.xsl (easily fixable)

second bsd diff is quite slow to perform a diff on such very large file.

Last the copyright at the top of every vuln-*.xml file will always disappear in the tidy version but not in the flat version always adding some noise.

I haven't made my mind yet, just throwing the first idea that are coming through my mind while reviewing ;)

Makefile
84

This should be the new variable you have been creating earlier

As these changes were commited, I will close this review.

This revision is now accepted and ready to land.Jan 26 2021, 8:37 PM