emacs-devel update
ClosedPublic
Actions

Authored by jrm on Jan 22 2021, 8:55 PM.

Details

Reviewers

rhurlin
tcberner

Commits

rP562363: math/ess: Fix build after latest editors/emacs-devel update

Summary

The 'when' argument of make-obsolete and related functions was recently
made mandatory. [1] Apply an upstream patch to a
`define-obsolete-function-alias' call to fix the build. [2]

[1] https://github.com/emacs-mirror/emacs/commit/32c6732d16385f242b1109517f25e9aefd6caa5c
[2] https://github.com/emacs-ess/ESS/commit/9cc5520e1998d03f5dec0fbb1fe71b7cdec38b65

PR:
Submitted by:
Reported by: tcberner

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm created this revision.Jan 22 2021, 8:55 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 22 2021, 8:55 PM

jrm requested review of this revision.Jan 22 2021, 8:55 PM

Harbormaster completed remote builds in B36409: Diff 82736.Jan 22 2021, 8:55 PM

jrm added reviewers: rhurlin, tcberner.Jan 22 2021, 8:56 PM

jrm edited the summary of this revision. (Show Details)

Hi Joseph,
Many thanks for the patch! I have also searched, but so far have not found the right thing :(

After patching my local math/ess, how can I build it with editors/emacs-devel? portmaster math/ess@devel or portmaster math/ess@devel-full does not work for me ...

In D28285#632850, @rhurlin wrote:

Hi Joseph,
Many thanks for the patch! I have also searched, but so far have not found the right thing :(

After patching my local math/ess, how can I build it with editors/emacs-devel? portmaster math/ess@devel or portmaster math/ess@devel-full does not work for me ...

I tested it in poudriere, and all flavours build fine:

[00:02:34] Built ports: math/ess@nox math/ess@devel_nox math/ess@canna math/ess@devel_full math/ess

mfg Tobias

In D28285#632850, @rhurlin wrote:

Hi Joseph,
Many thanks for the patch! I have also searched, but so far have not found the right thing :(

After patching my local math/ess, how can I build it with editors/emacs-devel? portmaster math/ess@devel or portmaster math/ess@devel-full does not work for me ...

Hi Rainer,

The two flavors that broke are devel_full and devel_nox. You can check the flavors for a port with make -VFLAVORS. I'm not certain about portmaster syntax. If you can tolerate a little unsolicited rant, I cringe a little when I see portmaster, because it's prone to spurious errors, unless you are really careful about building in a clean environment. If you can, testing with poudriere is superior, because it uses a pristine environment and it's what the official package builders use. I did test the fix in pourdriere and it looks good.

Joe

Hi Joseph,

Thanks for the help. @devel_full and @devel_nox work fine, instead of my trials with @devel-full and @devel-nox (minus instead of underscore).

I can give maintainer-approval ;) Would you commit the patch, please?

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2021, 2:42 AM

Closed by commit rP562363: math/ess: Fix build after latest editors/emacs-devel update (authored by jrm). · Explain Why

This revision was automatically updated to reflect the committed changes.

jrm added a commit: rP562363: math/ess: Fix build after latest editors/emacs-devel update.