Page MenuHomeFreeBSD

Complete Steps 5 and 9 from the Committer's guide
ClosedPublic

Authored by lcook on Jan 22 2021, 11:25 AM.

Details

Summary

Steps 5 and 9:

  • Update Mentor and Mentee Information
  • Update Ports with Personal Information

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

usr.bin/calendar/calendars/calendar.freebsd
41

I know not all entries are sorted, but can we move it two lines up so it is alphabetically sorted for 01/21?

  • Re-order calendar alphabetically as per suggestion

LGTM.

Just in case you need help with git: https://github.com/bsdimp/freebsd-git-docs/blob/main/src-cvt.md

If you have two commits (the original and the updated with the sorted fields) try to squash them as one.

This revision is now accepted and ready to land.Jan 22 2021, 11:48 AM

LGTM.

Just in case you need help with git: https://github.com/bsdimp/freebsd-git-docs/blob/main/src-cvt.md

If you have two commits (the original and the updated with the sorted fields) try to squash them as one.

Thanks. Just committed, although the log format is not as I expected. I'm guessing that arc land alters the commit log and that your typical git push is preferred?

LGTM.

Just in case you need help with git: https://github.com/bsdimp/freebsd-git-docs/blob/main/src-cvt.md

If you have two commits (the original and the updated with the sorted fields) try to squash them as one.

Thanks. Just committed, although the log format is not as I expected. I'm guessing that arc land alters the commit log and that your typical git push is preferred?

Do not use arc land as it does not do exactly what we want. Have a look at: https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview

It is a bit outdated now that 2/3 repos are in git, but still.

Also, you can have a look at this in case it helps: https://wiki.freebsd.org/FernandoApesteguia/MyReviewWorkflow

LGTM.

Just in case you need help with git: https://github.com/bsdimp/freebsd-git-docs/blob/main/src-cvt.md

If you have two commits (the original and the updated with the sorted fields) try to squash them as one.

Thanks. Just committed, although the log format is not as I expected. I'm guessing that arc land alters the commit log and that your typical git push is preferred?

Do not use arc land as it does not do exactly what we want. Have a look at: https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview

It is a bit outdated now that 2/3 repos are in git, but still.

Also, you can have a look at this in case it helps: https://wiki.freebsd.org/FernandoApesteguia/MyReviewWorkflow

Duly noted! Thank you for the clarification. :-)