Differential D28267

Create symlinks to host tools on non-FreeBSD hosts
ClosedPublic
Actions

Authored by arichardson on Jan 21 2021, 10:34 AM.

Tags

None

Referenced Files

	F105784169: D28267.id82682.diff
	Fri, Dec 20, 3:56 PM

	Unknown Object (File)
	Mon, Dec 9, 2:06 PM

	Unknown Object (File)
	Thu, Nov 28, 10:44 AM

	Unknown Object (File)
	Thu, Nov 28, 10:44 AM

	Unknown Object (File)
	Thu, Nov 28, 10:44 AM

	Unknown Object (File)
	Thu, Nov 28, 10:42 AM

	Unknown Object (File)
	Thu, Nov 28, 10:23 AM

	Unknown Object (File)
	Nov 19 2024, 4:37 AM

View All 61 Files

Subscribers

Details

Reviewers

jrtc27
imp
freebsdphab-AX9_cmx.ietfng.org

Commits

rGaa68a0b324cf: Create symlinks to host tools on non-FreeBSD hosts
rGa8b20f4fabbc: Create symlinks to host tools on non-FreeBSD hosts

Summary

This is unnecessary when cross-building from Linux/macOS.
Additionally, cp -p appears to be broken on macOS Big Sur
(https://openradar.appspot.com/8957219).

For some unknown reason this commit appears to fix
freezes when building on macOS Big Sur.
This also fixes building in docker with volume mounts
with ACLs, since setting the ACL with cp -p fails otherwise.

Obtained From: CheriBSD
Tested By: gnn (macOS Big Sur), Nathaniel Wesley Filardo (docker)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jan 21 2021, 10:34 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 21 2021, 10:34 AM

arichardson requested review of this revision.Jan 21 2021, 10:34 AM

Harbormaster completed remote builds in B36388: Diff 82681.Jan 21 2021, 10:35 AM

arichardson retitled this revision from Create symlinks to host tools (#896) to Create symlinks to host tools.Jan 21 2021, 10:38 AM

fix comments

Harbormaster completed remote builds in B36389: Diff 82682.Jan 21 2021, 10:39 AM

arichardson retitled this revision from Create symlinks to host tools to Create symlinks to host tools on non-FreeBSD hosts.Jan 21 2021, 10:42 AM

arichardson edited the summary of this revision. (Show Details)

arichardson added reviewers: jrtc27, nwf20_cl.cam.ac.uk.

arichardson added a reviewer: imp.

arichardson added a subscriber: gnn.

We only need the copies on FreeBSD to avoid the issue you cited. On other systems, symlinks are fine.

This revision is now accepted and ready to land.Jan 22 2021, 4:26 PM

"freezes when building failures on macOS" in the commit message needs fixing

arichardson edited the summary of this revision. (Show Details)Jan 22 2021, 4:34 PM

jrtc27 accepted this revision.Jan 25 2021, 2:12 PM

jrtc27 edited reviewers, added: freebsdphab-AX9_cmx.ietfng.org; removed: nwf20_cl.cam.ac.uk.Jan 25 2021, 2:31 PM

Closed by commit rGa8b20f4fabbc: Create symlinks to host tools on non-FreeBSD hosts (authored by arichardson). · Explain WhyJan 25 2021, 3:12 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGa8b20f4fabbc: Create symlinks to host tools on non-FreeBSD hosts.

arichardson added a commit: rGaa68a0b324cf: Create symlinks to host tools on non-FreeBSD hosts.Mar 17 2021, 10:29 AM

Revision Contents
Changeset List

Path

Size

tools/

build/

18 lines

Diff 82850

tools/build/Makefile

Loading...