Page MenuHomeFreeBSD
Differential D28213

Reuse the amd64 loader relocation code on arm64
ClosedPublic
Actions

Authored by andrew on Jan 17 2021, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 6, 12:02 PM
Unknown Object (File)
Mon, May 4, 3:04 PM
Unknown Object (File)
Thu, Apr 30, 11:28 AM
Unknown Object (File)
Thu, Apr 30, 8:49 AM
Unknown Object (File)
Tue, Apr 28, 1:41 PM
Unknown Object (File)
Tue, Apr 28, 3:16 AM
Unknown Object (File)
Thu, Apr 23, 4:28 PM
Unknown Object (File)
Thu, Apr 23, 8:18 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
arm64
Commits
rGf6f0b849fb26: Reuse the amd64 loader relocation code on arm64
Summary

There is no need to keep multiple copies of the relocation code. The
amd64 code works on arm64 with a few small changes to relocation types.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Jan 17 2021, 6:22 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 17 2021, 6:22 PM
andrew requested review of this revision.Jan 17 2021, 6:22 PM
Harbormaster completed remote builds in B36300: Diff 82432.Jan 17 2021, 6:22 PM
kib added a comment.Jan 18 2021, 5:45 PM

I must admit it is a weird source before the change. IMO we should split this code into per-arch file/function, not merge arches.

But I do not deal with this code, so this is only an opinion.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2021, 6:33 PM
Closed by commit rGf6f0b849fb26: Reuse the amd64 loader relocation code on arm64 (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGf6f0b849fb26: Reuse the amd64 loader relocation code on arm64.

Revision Contents
Changeset List

PathSize
stand/
common/
35 lines

Diff 82646

View Options

stand/common/reloc_elf.c

Loading...