Page MenuHomeFreeBSD

Reuse the amd64 loader relocation code on arm64
ClosedPublic

Authored by andrew on Jan 17 2021, 6:22 PM.

Details

Summary

There is no need to keep multiple copies of the relocation code. The
amd64 code works on arm64 with a few small changes to relocation types.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I must admit it is a weird source before the change. IMO we should split this code into per-arch file/function, not merge arches.

But I do not deal with this code, so this is only an opinion.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2021, 6:33 PM
This revision was automatically updated to reflect the committed changes.