Page MenuHomeFreeBSD

compiler.mk: Update clang dependency from v6 to v10, clean up duplication
Needs ReviewPublic

Authored by jrm on Tue, Jan 12, 8:11 PM.

Details

Reviewers
swills
brooks
linimon
pkubaj
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

PR:
Submitted by:
Reported by:

Test Plan

Will request an exp run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 36148
Build 33037: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Tue, Jan 12, 8:11 PM
jrm retitled this revision from compiler.mk: Update clang dependency from v10, clean up duplication to compiler.mk: Update clang dependency from v6 to v10, clean up duplication.
Mk/Uses/compiler.mk
174

I'd usually put parenthesizes around the && blocks rather than trusting operator precedence.

179

Does it make sense to remove this OBE case while you're here (or as a new review)?

jrm added inline comments.
Mk/Uses/compiler.mk
179

I lean towards a separate review with some reviewers who work on other architectures, because I don't have access to most of the tier 2+ architectures for testing. Or, are you confident that it's no longer necessary?

Mk/Uses/compiler.mk
179

Separate review is fine and probably necessary. It's not the case that all Tier 2 arches use clang because sparc64 exists (I keep forgetting it's still around in stable). This should be changed so all supported arches in 13 default to clang, but that will probably require testing.