PR: 252627
Submitted by:
Reported by:
Details
- Reviewers
swills brooks linimon pkubaj - Group Reviewers
O5: Ports Framework portmgr - Commits
- rP562226: compiler.mk: Update clang dependency to v10; clean up duplication
exp run passed: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252627
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Mk/Uses/compiler.mk | ||
---|---|---|
179 ↗ | (On Diff #82170) | I lean towards a separate review with some reviewers who work on other architectures, because I don't have access to most of the tier 2+ architectures for testing. Or, are you confident that it's no longer necessary? |
Mk/Uses/compiler.mk | ||
---|---|---|
179 ↗ | (On Diff #82170) | Separate review is fine and probably necessary. It's not the case that all Tier 2 arches use clang because sparc64 exists (I keep forgetting it's still around in stable). This should be changed so all supported arches in 13 default to clang, but that will probably require testing. |
Mk/Uses/compiler.mk | ||
---|---|---|
174 ↗ | (On Diff #82170) | I just wanted to wait for the exp-run to finish before making any code changes. The exp-run does pass, but are you aware of an issue with operator precedence? Or, do you mean the ( ) improves readability? |
Mk/Uses/compiler.mk | ||
---|---|---|
174 ↗ | (On Diff #82170) | IMO ( ) improves readability. I'd rather not have to think about any but the most trivial precedence rules (obviously a subjective thing) when reading large conditionals. |
Incorporate Brooks' suggestion to add extra parentheses, so readers do not need to think about operator precedence