Differential D2809

Fix an orphan bug and add tests for fork following.
ClosedPublic
Actions

Authored by jhb on Jun 14 2015, 5:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 6:06 AM

	Unknown Object (File)
	Dec 21 2024, 10:28 AM

	Unknown Object (File)
	Dec 10 2024, 2:10 PM

	Unknown Object (File)
	Nov 23 2024, 3:47 AM

	Unknown Object (File)
	Nov 11 2024, 3:20 AM

	Unknown Object (File)
	Oct 3 2024, 10:02 PM

	Unknown Object (File)
	Oct 1 2024, 5:04 AM

	Unknown Object (File)
	Sep 10 2024, 10:24 AM

View All 73 Files

Subscribers

Details

Reviewers

Commits

rS286158: Clear P_TRACED before reparenting a detached process back to its

Summary

Clear P_TRACED before reparenting a detached process back to its
original parent. Otherwise the debugee will be set as an orphan of
the debugger.

Add tests for tracing forks via PT_FOLLOW_FORK.

Test Plan

The ptrace__follow_fork_parent_detached_unrelated_debugger hangs without the change in sys_process.c. The debugger is hung in wait because when it calls the last wait, the orphan from the parent is still present, but after init harvests the parent it stays asleep with no orphans and no children.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 6182.Jun 14 2015, 5:20 AM

jhb retitled this revision from to Fix an orphan bug and add tests for fork following..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: kib.

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 14 2015, 5:20 AM

kib accepted this revision.Jun 14 2015, 6:28 AM

kib edited edge metadata.

kib added inline comments.

sys/kern/sys_process.c
950 ↗	(On Diff #6182)	I think the comment which is equivalent to the explanation message of the revision, should be added there.

This revision is now accepted and ready to land.Jun 14 2015, 6:28 AM

emaste added inline comments.Jun 15 2015, 1:53 AM

sys/kern/sys_process.c
950 ↗	(On Diff #6182)	That sounds reasonable to me.

Rebase
Document why P_TRACED needs to be cleared.

This revision now requires review to proceed.Aug 1 2015, 5:47 AM

kib accepted this revision.Aug 1 2015, 6:05 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2015, 6:05 AM

Closed by commit rS286158: Clear P_TRACED before reparenting a detached process back to its (authored by jhb). · Explain WhyAug 1 2015, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

11 lines

tests/

sys/

kern/

581 lines

Diff 7570

head/sys/kern/sys_process.c

Loading...

head/tests/sys/kern/ptrace_test.c

Loading...