Details
Details
- Reviewers
tz - Commits
- rP561112: MFH: r560820
rP560820: Fix JIT support in the PHP8 build
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
@tz thank you. One thing i am still missing - if i am compiling it manually, w/o poudriere, it sets cpu to x86_64. Some autoconf magic :) Will try to find a bit more, may be this will lead to a better solution
Comment Actions
@tz i found that! PHP has config.guess file in it distro which is _newer_ then in autoconf and has correct host name. When we compiling everything from source - its distributed for all the extensions, but if we not doing that - its not. For opcache its became a critical thing. So let me rework the patch.
Comment Actions
@tz a bit more information:
- PHP has more recent config.guess then autoconf config.guess/config.sub which sets cpu target as x86_64 on amd64 FreeBSD arch
- This is correctly handled if building from source, but not when from port, as we are using autoreconf -i -f which overrides all files in build.
- I was able to fix that but this will introduce too many hacks in lang/php80, so as we need this for only one extension - i would better leave it as is.
- Hopefully when autoconf will be updated by upstream this hack will not be needed anymore