Page MenuHomeFreeBSD

Add JIT support to the PHP8 build
ClosedPublic

Authored by samm on Jan 8 2021, 6:15 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

samm requested review of this revision.Jan 8 2021, 6:15 PM

Works like charm samm, thank you very much! :) Feel free to commit it! :)

This revision is now accepted and ready to land.Jan 8 2021, 8:52 PM

@tz thank you. One thing i am still missing - if i am compiling it manually, w/o poudriere, it sets cpu to x86_64. Some autoconf magic :) Will try to find a bit more, may be this will lead to a better solution

@tz i found that! PHP has config.guess file in it distro which is _newer_ then in autoconf and has correct host name. When we compiling everything from source - its distributed for all the extensions, but if we not doing that - its not. For opcache its became a critical thing. So let me rework the patch.

@tz a bit more information:

  1. PHP has more recent config.guess then autoconf config.guess/config.sub which sets cpu target as x86_64 on amd64 FreeBSD arch
  2. This is correctly handled if building from source, but not when from port, as we are using autoreconf -i -f which overrides all files in build.
  3. I was able to fix that but this will introduce too many hacks in lang/php80, so as we need this for only one extension - i would better leave it as is.
  4. Hopefully when autoconf will be updated by upstream this hack will not be needed anymore
This revision was automatically updated to reflect the committed changes.