Differential D28036

dtrace tests: fix prototypes for gcc build
ClosedPublic
Actions

Authored by rlibby on Jan 8 2021, 7:33 AM.

Tags

None

Referenced Files

	F137355164: D28036.id81871.diff
	Sat, Nov 22, 6:17 PM

	Unknown Object (File)
	Fri, Nov 7, 4:28 AM

	Unknown Object (File)
	Thu, Oct 30, 8:15 PM

	Unknown Object (File)
	Wed, Oct 29, 12:28 PM

	Unknown Object (File)
	Wed, Oct 29, 12:18 PM

	Unknown Object (File)
	Wed, Oct 29, 12:18 PM

	Unknown Object (File)
	Wed, Oct 29, 12:18 PM

	Unknown Object (File)
	Wed, Oct 29, 12:17 PM

Subscribers

Details

Reviewers

markj
gnn

Commits

rGc14e17a49cdd: dtrace tests: fix prototypes for gcc build

Summary

quiet -Wstrict-prototypes
provide prototypes for weak aliases

Test Plan

Build with clang and gcc, nm output looks good.

env MAKEOBJDIRPREFIX=/usr/obj/gcc9 CROSS_TOOLCHAIN=amd64-gcc9 make WITH_DTRACE_TESTS=YES buildworld
make WITH_DTRACE_TESTS=YES buildworld

% nm /usr/obj/usr/src/freebsd/amd64.amd64/cddl/usr.sbin/dtrace/tests/common/pid/tst.weak1.o
0000000000000000 W _go
                 U exit
                 U getpid
0000000000000000 T go
0000000000000040 t handle
0000000000000010 T main
                 U signal
% nm /usr/obj/gcc9/usr/src/freebsd/amd64.amd64/cddl/usr.sbin/dtrace/tests/common/pid/tst.weak1.o  
0000000000000000 W _go
                 U exit
                 U getpid
0000000000000000 T go
000000000000000f t handle
000000000000002e T main
                 U signal

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jan 8 2021, 7:33 AM

Herald added a reviewer: gnn. · View Herald TranscriptJan 8 2021, 7:33 AM

Herald added a subscriber: imp. · View Herald Transcript

rlibby requested review of this revision.Jan 8 2021, 7:33 AM

Harbormaster completed remote builds in B36022: Diff 81871.Jan 8 2021, 7:33 AM

markj accepted this revision.Jan 8 2021, 3:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2021, 5:55 AM

Closed by commit rGc14e17a49cdd: dtrace tests: fix prototypes for gcc build (authored by rlibby). · Explain Why

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rGc14e17a49cdd: dtrace tests: fix prototypes for gcc build.

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

cmd/

dtrace/

test/

tst/

common/

java_api/

tst.FunctionLookup.c

2 lines

tst.ProbeData.c

2 lines

pid/

5 lines

6 lines

Diff 82054

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/java_api/tst.FunctionLookup.c

Loading...

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/java_api/tst.ProbeData.c

Loading...

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/pid/tst.weak1.c

Loading...

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/pid/tst.weak2.c

Loading...