Simplify dynamic ipfilter sysctls.
ClosedPublic
Actions

Authored by jhb on Jan 4 2021, 9:39 PM.

Tags

None

Referenced Files

	F166653265: D27961.diff
	Sat, Aug 15, 6:04 AM

	Unknown Object (File)
	Sun, Aug 9, 12:40 PM

	Unknown Object (File)
	Sun, Aug 9, 12:40 PM

	Unknown Object (File)
	Tue, Aug 4, 3:55 AM

	Unknown Object (File)
	Mon, Aug 3, 9:28 PM

	Unknown Object (File)
	Mon, Aug 3, 3:32 PM

	Unknown Object (File)
	Sun, Aug 2, 8:25 AM

	Unknown Object (File)
	Sun, Jul 19, 3:44 PM

View All Files

Subscribers

imp

Details

Reviewers

bz
cy

Commits

rGbb4cbd0fcf3e: Simplify dynamic ipfilter sysctls.
rGd86d3194955c: Simplify dynamic ipfilter sysctls.

Summary

Pass the structure offset in arg2 instead of arg1. This avoids
having to undo the pointer arithmetic on arg1. Instead arg2 can
be used directly as an offset relative to the desired structure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 4 2021, 9:39 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 4 2021, 9:39 PM

jhb requested review of this revision.Jan 4 2021, 9:39 PM

Harbormaster completed remote builds in B35929: Diff 81648.Jan 4 2021, 9:39 PM

Ping @cy

Definitely an improvement. Thank you.

This revision is now accepted and ready to land.Jan 20 2021, 5:17 PM

Closed by commit rGd86d3194955c: Simplify dynamic ipfilter sysctls. (authored by jhb). · Explain WhyJan 21 2021, 12:35 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd86d3194955c: Simplify dynamic ipfilter sysctls..

cy added a commit: rGbb4cbd0fcf3e: Simplify dynamic ipfilter sysctls..Jul 14 2022, 9:33 PM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ipfilter/

netinet/

mlfk_ipl.c

86 lines

Diff 82663

View Options

sys/contrib/ipfilter/netinet/mlfk_ipl.c

Simplify dynamic ipfilter sysctls.ClosedPublicActions