Page MenuHomeFreeBSD

databases/libmswstr: New port, version 0.0.1
ClosedPublic

Authored by rhurlin on Jan 4 2021, 6:36 PM.

Details

Summary

This port provides functionality that allows applications such as databases/mdbtools to use indexes from Microsoft Access databases in JET4 format. The data and structures of libmswstr [1] have been reverse engineered.

Before committing this port to FreeBSD, it should be clarified absolutely sufficiently, whether possibly license rights are hurt. My estimation is that this port can be classified under licensing law rather like multimedia/dvdread and similar and thus be included in the port tree?! This seems also the opinion of the mdbtools project [2]: "Pulling out translation tables is probably a copyright-safe thing to do."

[1] https://github.com/leecher1337/libmswstr/blob/master/COPYING
[2] https://github.com/mdbtools/mdbtools/issues/215#issuecomment-748102302

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

databases/libmswstr/Makefile
24 ↗(On Diff #81636)

^ could you add a proper patch for this?

Actually, I know that this kind of patch is solved via a regular patch file.

I had been irritated by error messages in a previous version, because I had applied the patch to the file before dos2unix had changed the line endings unix-like ...

Now it should work ;)

Do you have an opinion on the licensing aspect? Gleb suggests in a PM to ask also under ports@ if in doubt. I'm afraid there won't be an opinion that is clear enough.

Actually, I know that this kind of patch is solved via a regular patch file.

I had been irritated by error messages in a previous version, because I had applied the patch to the file before dos2unix had changed the line endings unix-like ...

Now it should work ;)

Do you have an opinion on the licensing aspect? Gleb suggests in a PM to ask also under ports@ if in doubt. I'm afraid there won't be an opinion that is clear enough.

Sorry, not a lawyer :D -- in my opinion I don't see a reason not to add it.

Actually, I know that this kind of patch is solved via a regular patch file.

I had been irritated by error messages in a previous version, because I had applied the patch to the file before dos2unix had changed the line endings unix-like ...

Now it should work ;)

Do you have an opinion on the licensing aspect? Gleb suggests in a PM to ask also under ports@ if in doubt. I'm afraid there won't be an opinion that is clear enough.

Sorry, not a lawyer :D -- in my opinion I don't see a reason not to add it.

Thanks for the reply. I have not received any answer on ports@ so far. And I think there will be no (qualified) response anymore ...

Do you think you could give me approval for the patch? Then I would like to commit it :)

Minor nit-pick in the Makefile, but otherwise lgtm

databases/libmswstr/Makefile
7 ↗(On Diff #81872)

^ is this really necessary?

This revision is now accepted and ready to land.Jan 11 2021, 8:15 PM
rhurlin marked an inline comment as done.

I must have missed that, thanks! It works very well without DISTNAME.

This revision now requires review to proceed.Jan 11 2021, 9:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2021, 9:36 PM
This revision was automatically updated to reflect the committed changes.