Page MenuHomeFreeBSD
Differential D27849

Fix a couple of issues in kgdb.
ClosedPublic
Actions

Authored by jhb on Dec 30 2020, 5:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 1:34 PM
Unknown Object (File)
Sat, Oct 4, 9:19 AM
Unknown Object (File)
Wed, Oct 1, 7:29 AM
Unknown Object (File)
Tue, Sep 30, 4:48 AM
Unknown Object (File)
Tue, Sep 23, 6:17 AM
Unknown Object (File)
Fri, Sep 19, 10:31 PM
Unknown Object (File)
Fri, Sep 19, 10:27 PM
Unknown Object (File)
Fri, Sep 19, 10:15 PM
View All Files
Subscribers
emaste
mat

Details

Reviewers
pizzamig
Commits
rP560808: Fix a couple of issues in kgdb.
Summary
  • Properly unwind across in-kernel exceptions on arm.
  • Enumerate processes via the pid hash table for kernels without the zombproc list.

PR: 251463 (1)

Test Plan
  • I've tested the zombproc fix on a recent panic on head during exit1() where kgdb didn't see the panicking thread without the fix.
  • The OP for the PR has not tested the arm patch, but I beleive it to be correct.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 30 2020, 5:54 PM
Herald added subscribers: mat, emaste. · View Herald TranscriptDec 30 2020, 5:54 PM
Harbormaster completed remote builds in B35794: Diff 81374.Dec 30 2020, 5:54 PM
jhb requested review of this revision.Dec 30 2020, 5:54 PM
pizzamig accepted this revision.Jan 4 2021, 9:05 PM

It looks good to me.
I tested the build on the available platform and I don't have a way to test on arm.
However, it's good to be committed

This revision is now accepted and ready to land.Jan 4 2021, 9:05 PM
Closed by commit rP560808: Fix a couple of issues in kgdb. (authored by jhb). · Explain WhyJan 8 2021, 8:15 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rP560808: Fix a couple of issues in kgdb..

Revision Contents
Changeset List

PathSize
head/
devel/
gdb/
2 lines
files/
kgdb/
19 lines
181 lines

Diff 81911

View Options

head/devel/gdb/Makefile

Loading...
View Options

head/devel/gdb/files/kgdb/arm-fbsd-kern.c

Loading...
View Options

head/devel/gdb/files/kgdb/fbsd-kthr.c

Loading...