camcontrol: stop pretending cam_cmd is a bitmask
ClosedPublic
Actions

Authored by trasz on Dec 29 2020, 5:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 2, 12:16 AM

	Unknown Object (File)
	Thu, Nov 27, 12:28 PM

	Unknown Object (File)
	Sun, Nov 23, 11:02 PM

	Unknown Object (File)
	Sat, Nov 22, 3:19 AM

	Unknown Object (File)
	Wed, Nov 19, 9:22 AM

	Unknown Object (File)
	Nov 11 2025, 2:02 PM

	Unknown Object (File)
	Oct 8 2025, 2:56 AM

	Unknown Object (File)
	Oct 1 2025, 3:04 AM

View All 87 Files

Subscribers

NetApp

Details

Reviewers

imp

Commits

rGf848d08e4528: camcontrol: stop pretending cam_cmd is a bitmask

Summary

Cleanup only, no functional changes.

camcontrol(8): remove unnecessary CCB zeroing

After 3e404b8c53d, cam_getccb(3) clears the returned CCB, making
a number of calls to CCB_CLEAR_ALL_EXCEPT_HDR(3) unnecessary.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 35749
Build 32638: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Dec 29 2020, 5:19 PM

trasz created this revision.

Harbormaster completed remote builds in B35748: Diff 81311.Dec 29 2020, 5:19 PM

Drop unneeded changes.

Harbormaster completed remote builds in B35749: Diff 81312.Dec 29 2020, 5:26 PM

(Tinderboxed.)

allanjude added a subscriber: NetApp.Feb 16 2021, 4:12 PM

imp accepted this revision.Feb 16 2021, 6:29 PM

This revision is now accepted and ready to land.Feb 16 2021, 6:29 PM

Closed by commit rGf848d08e4528: camcontrol: stop pretending cam_cmd is a bitmask (authored by trasz). · Explain WhyFeb 25 2021, 6:43 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rGf848d08e4528: camcontrol: stop pretending cam_cmd is a bitmask.

Revision Contents
Changeset List

Path

Size

sbin/

camcontrol/

camcontrol.c

94 lines

Diff 81312

View Options

sbin/camcontrol/camcontrol.c

camcontrol: stop pretending cam_cmd is a bitmaskClosedPublicActions