Page MenuHomeFreeBSD
Differential D2773

pf: Remove frc_direction
ClosedPublic
Actions

Authored by kp on Jun 10 2015, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 5 2024, 2:01 PM
Unknown Object (File)
Sep 23 2024, 10:25 PM
Unknown Object (File)
Sep 21 2024, 6:45 AM
Unknown Object (File)
Sep 17 2024, 4:30 AM
Unknown Object (File)
Sep 15 2024, 3:32 PM
Unknown Object (File)
Sep 15 2024, 1:54 PM
Unknown Object (File)
Sep 13 2024, 10:38 PM
Unknown Object (File)
Sep 13 2024, 10:38 PM
View All 46 Files
Subscribers
imp

Details

Reviewers
philip
gnn
Summary

We don't use the direction of the fragments for anything. The frc_direction
field is assigned, but never read.
Just remove it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kp updated this revision to Diff 6091.Jun 10 2015, 11:27 PM
kp retitled this revision from to pf: Remove frc_direction.
kp updated this object.
kp edited the test plan for this revision. (Show Details)
kp added reviewers: gnn, philip.
kp set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 10 2015, 11:27 PM
philip edited edge metadata.Jun 11 2015, 3:30 AM

Do more recent versions of OpenBSD use this field for anything? In other words: will this make merge-hell even hotter when (if?) we want to pull in more recent pf code from OpenBSD?

kp added a comment.Jun 11 2015, 3:32 AM

OpenBSD still has the field, but also doesn't use it for anything.

philip accepted this revision.Jun 11 2015, 5:49 PM
philip edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2015, 5:49 PM
kp closed this revision.Jun 11 2015, 6:15 PM

Submitted as r284280.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
10 lines

Diff 6091

View Options

sys/netpfil/pf/pf_norm.c

Loading...