Page MenuHomeFreeBSD

sendfile: Ensure that sfio->npages is initialized
ClosedPublic

Authored by markj on Dec 22 2020, 5:31 PM.
Tags
None
Referenced Files
F124898158: D27726.id81063.diff
Fri, Aug 1, 3:01 AM
Unknown Object (File)
Tue, Jul 22, 7:13 AM
Unknown Object (File)
Sun, Jul 13, 9:23 PM
Unknown Object (File)
Mon, Jul 7, 7:55 AM
Unknown Object (File)
Fri, Jul 4, 7:22 AM
Unknown Object (File)
Jun 29 2025, 11:27 AM
Unknown Object (File)
Jun 22 2025, 5:18 AM
Unknown Object (File)
Jun 22 2025, 4:16 AM
Subscribers

Details

Summary

We initialize sfio->npages only when some I/O is required to satisfy the
request. However, sendfile_iodone() contains an INVARIANTS-only check
that references sfio->npages, and this check is executed even if no I/O
is performed, so the check may use an uninitialized value.

Fix the problem by initializing sfio->npages earlier. Note that
sendfile_swapin() always initializes the page array. In some rare cases
we need to trim the page array so ensure that sfio->npages gets updated
accordingly.

Test Plan

syzkaller triggered the bug and KASAN detected it because the uninitialized
value caused the loop in sendfile_iodone() to run past the end of the buffer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable