Page MenuHomeFreeBSD
Differential D27688

pf tests: Verify (tcp) checksum modification on unaligned options
AbandonedPublic
Actions

Authored by kp on Dec 20 2020, 3:02 PM.
Tags
None
Referenced Files
F156733006: D27688.id81015.diff
Fri, May 15, 11:55 PM
F156732974: D27688.id80975.diff
Fri, May 15, 11:55 PM
F156732953: D27688.diff
Fri, May 15, 11:55 PM
Unknown Object (File)
Tue, May 12, 8:08 AM
Unknown Object (File)
Sat, May 2, 12:57 PM
Unknown Object (File)
Sun, Apr 26, 5:59 PM
Unknown Object (File)
Sun, Apr 19, 11:16 PM
Unknown Object (File)
Thu, Apr 16, 4:13 PM
View All Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
Commits
rG5c712c8748f3: pf tests: Verify (tcp) checksum modification on unaligned options
Summary

It turns out pf incorrectly updates the TCP checksum if the TCP option
we're modifying is not 2-byte algined with respect to the start of the
packet.

Create a TCP packet with such an option and throw it through a scrub
rule, which will update timestamps and modify the packet.

PR: 240416

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35584
Build 32484: arc lint + arc unit

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
common/
69 lines
pf/
1 line
85 lines

Diff 81015

View Options

tests/sys/netpfil/common/pft_ping.py

Loading...
View Options

tests/sys/netpfil/pf/Makefile

Loading...
View Options

tests/sys/netpfil/pf/checksum.sh

Loading...