Don't try to adjust a TLS TOE socket that has been closed.
ClosedPublic
Actions

Authored by jhb on Dec 11 2020, 9:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 15, 12:40 PM

	Unknown Object (File)
	Sat, Aug 15, 5:26 AM

	Unknown Object (File)
	Fri, Aug 14, 9:59 PM

	Unknown Object (File)
	Tue, Aug 11, 1:39 PM

	Unknown Object (File)
	Mon, Aug 10, 9:47 AM

	Unknown Object (File)
	Sun, Aug 9, 5:42 PM

	Unknown Object (File)
	Tue, Aug 4, 1:30 AM

	Unknown Object (File)
	Tue, Aug 4, 1:30 AM

View All Files

Subscribers

imp

Details

Reviewers

Commits

rG672784750001: Don't try to adjust a TLS TOE socket that has been closed.

Summary

The handshake timer can race with another thread sending a FIN or RST
to close a TOE TLS socket. Just bail from the timer without
rescheduling if the connection is closed when the timer fires.

Test Plan

tested by Chelsio QA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 11 2020, 9:42 PM

Herald added subscribers: ae, imp. · View Herald TranscriptDec 11 2020, 9:42 PM

jhb requested review of this revision.Dec 11 2020, 9:42 PM

Harbormaster completed remote builds in B35363: Diff 80612.Dec 11 2020, 9:43 PM

np accepted this revision.Dec 20 2020, 7:14 AM

This revision is now accepted and ready to land.Dec 20 2020, 7:14 AM

Closed by commit rG672784750001: Don't try to adjust a TLS TOE socket that has been closed. (authored by jhb). · Explain WhyDec 30 2020, 6:02 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG672784750001: Don't try to adjust a TLS TOE socket that has been closed..

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

tom/

t4_tls.c

4 lines

Diff 81375

View Options

sys/dev/cxgbe/tom/t4_tls.c

Don't try to adjust a TLS TOE socket that has been closed.ClosedPublicActions