atkbd(4): Just use nitems() for quirk enumeration
ClosedPublic
Actions

Authored by cem on Dec 5 2020, 8:43 PM.

Tags

None

Referenced Files

	F147739289: D27489.id80369.diff
	Fri, Mar 13, 7:53 AM

	F147725488: D27489.id80369.diff
	Fri, Mar 13, 5:39 AM

	F147696130: D27489.id80369.diff
	Fri, Mar 13, 12:06 AM

	Unknown Object (File)
	Fri, Mar 6, 9:31 AM

	Unknown Object (File)
	Mon, Mar 2, 7:31 PM

	Unknown Object (File)
	Mon, Mar 2, 1:31 PM

	Unknown Object (File)
	Dec 12 2025, 6:26 AM

	Unknown Object (File)
	Dec 4 2025, 8:35 PM

View All 79 Files

Subscribers

imp

Details

Reviewers

wulf
emaste
imp

Commits

rS368689: MFC: r367349, r367854, r368365, r368374(by cem)
rS368374: atkbd(4): Just use nitems() for quirk enumeration

Summary

X-MFC-With: r368365

Test Plan

nitems is commonly used for enumerating these statically-sized tables, and is
(IMO) clearer here.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Dec 5 2020, 8:43 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2020, 8:43 PM

cem requested review of this revision.Dec 5 2020, 8:43 PM

Harbormaster completed remote builds in B35208: Diff 80369.Dec 5 2020, 8:44 PM

Looks clearer to me too, and this isn't a linker set or anything else you have to take pains with...

This revision is now accepted and ready to land.Dec 5 2020, 9:30 PM

LGTM

Thanks for the quick look, folks!

Closed by commit rS368374: atkbd(4): Just use nitems() for quirk enumeration (authored by cem). · Explain WhyDec 5 2020, 10:04 PM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS368374: atkbd(4): Just use nitems() for quirk enumeration.

wulf added a commit: rS368689: MFC: r367349, r367854, r368365, r368374(by cem).Dec 16 2020, 8:00 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

atkbdc/

atkbdc.c

4 lines

Diff 80371

View Options

head/sys/dev/atkbdc/atkbdc.c

atkbd(4): Just use nitems() for quirk enumerationClosedPublicActions