Page MenuHomeFreeBSD
Differential D27489

atkbd(4): Just use nitems() for quirk enumeration
ClosedPublic
Actions

Authored by cem on Dec 5 2020, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 1:33 AM
Unknown Object (File)
Sun, Oct 19, 4:14 AM
Unknown Object (File)
Sat, Oct 18, 8:36 PM
Unknown Object (File)
Sat, Oct 18, 8:30 PM
Unknown Object (File)
Sat, Oct 18, 4:43 PM
Unknown Object (File)
Tue, Oct 14, 2:49 AM
Unknown Object (File)
Tue, Oct 14, 2:49 AM
Unknown Object (File)
Tue, Oct 14, 2:49 AM
View All 66 Files
Subscribers
imp

Details

Reviewers
wulf
emaste
imp
Commits
rS368689: MFC: r367349, r367854, r368365, r368374(by cem)
rS368374: atkbd(4): Just use nitems() for quirk enumeration
Summary

X-MFC-With: r368365

Test Plan

nitems is commonly used for enumerating these statically-sized tables, and is
(IMO) clearer here.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem created this revision.Dec 5 2020, 8:43 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 5 2020, 8:43 PM
cem requested review of this revision.Dec 5 2020, 8:43 PM
Harbormaster completed remote builds in B35208: Diff 80369.Dec 5 2020, 8:44 PM
imp accepted this revision.Dec 5 2020, 9:30 PM

Looks clearer to me too, and this isn't a linker set or anything else you have to take pains with...

This revision is now accepted and ready to land.Dec 5 2020, 9:30 PM
wulf accepted this revision.Dec 5 2020, 10:00 PM

LGTM

cem added a comment.Dec 5 2020, 10:04 PM

Thanks for the quick look, folks!

Closed by commit rS368374: atkbd(4): Just use nitems() for quirk enumeration (authored by cem). · Explain WhyDec 5 2020, 10:04 PM
This revision was automatically updated to reflect the committed changes.
cem added a commit: rS368374: atkbd(4): Just use nitems() for quirk enumeration.
wulf added a commit: rS368689: MFC: r367349, r367854, r368365, r368374(by cem).Dec 16 2020, 8:00 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
atkbdc/
4 lines

Diff 80371

View Options

head/sys/dev/atkbdc/atkbdc.c

Loading...