Differential D27476

Retire GNU_GREP_COMPAT knob
ClosedPublic
Actions

Authored by kevans on Dec 4 2020, 3:28 PM.

Tags

None

Referenced Files

	F83053138: D27476.id80350.diff
	Sun, May 5, 3:31 PM

	Unknown Object (File)
	Sep 24 2023, 6:46 AM

	Unknown Object (File)
	Aug 31 2023, 9:40 PM

	Unknown Object (File)
	Aug 26 2023, 2:34 PM

	Unknown Object (File)
	Aug 13 2023, 6:33 AM

	Unknown Object (File)
	Aug 6 2023, 5:46 PM

	Unknown Object (File)
	Aug 6 2023, 5:45 PM

	Unknown Object (File)
	Aug 6 2023, 5:42 PM

View All 19 Files

Subscribers

Details

Reviewers

Commits

rS368355: Retire GNU_GREP_COMPAT knob

Summary

This was introduced and then disabled by default primarily to avoid dealing with bugs in libgnuregex. rS363823 switched to using libregex for it, so let's just rip the option out now so we can make sure we're getting tested with libregex via bsdgrep.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Dec 4 2020, 3:28 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptDec 4 2020, 3:28 PM

Harbormaster completed remote builds in B35189: Diff 80313.Dec 4 2020, 3:28 PM

kevans requested review of this revision.Dec 4 2020, 3:28 PM

emaste accepted this revision.Dec 4 2020, 3:44 PM

emaste added inline comments.

usr.bin/grep/grep.c
561 ↗	(On Diff #80313)	can we gc the unused errstr now

This revision is now accepted and ready to land.Dec 4 2020, 3:44 PM

kevans added inline comments.Dec 4 2020, 3:55 PM

usr.bin/grep/grep.c
561 ↗	(On Diff #80313)	Oh, sure, I'll rip that out, too.

Closed by commit rS368355: Retire GNU_GREP_COMPAT knob (authored by kevans). · Explain WhyDec 5 2020, 2:22 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS368355: Retire GNU_GREP_COMPAT knob.

Revision Contents
Changeset List

Path

Size

head/

share/

mk/

1 line

tools/

build/

options/

WITHOUT_GNU_GREP_COMPAT

3 lines

WITH_GNU_GREP_COMPAT

4 lines

usr.bin/

grep/

3 lines

7 lines

Diff 80350

head/share/mk/src.opts.mk

Loading...

head/tools/build/options/WITHOUT_GNU_GREP_COMPAT

Loading...

head/tools/build/options/WITH_GNU_GREP_COMPAT

Loading...

head/usr.bin/grep/Makefile

Loading...

head/usr.bin/grep/grep.c

Loading...